Crosshair fix broken video #992
Merged
+283
−104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jotego
requested changes
Mar 4, 2025
jotego
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reapplies the commits for using the mouse as lightgun and fixes broken video in Mister
commit 490f471 was reverted because its parent commit was wrong messing some file locations, removing modules and undoing changes previously applied.
Apparently, video breaks in Mister when it has to take lhbl and lvbl from within the crosshair module, whether they have been delayed by the crosshair module or the input is directly assigned as an output. I don`t understand the reason behind this behaviour, but video still seems to fit the screen correctly in mister when ignoring the delayed blankings
Related to #989