Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

White borders for lightgun detection #997

Merged
merged 19 commits into from
Mar 21, 2025
Merged

White borders for lightgun detection #997

merged 19 commits into from
Mar 21, 2025

Conversation

rp-jt
Copy link
Collaborator

@rp-jt rp-jt commented Mar 7, 2025

Modified the Mister scaler to add white borders (needed as reference for Sinden lightguns) and reduce the size of the image when signal is enabled.

Border enabling signal is now associated to debug_bus[7] at jtframe_mister level. This should be changed so the signal can be enabled in the OSD for Lightgun games

@rp-jt rp-jt requested a review from jotego March 7, 2025 14:35
@@ -113,6 +113,7 @@ module jtframe_board #(parameter

// Lightguns
output [ 8:0] gun_1p_x, gun_1p_y, gun_2p_x, gun_2p_y,
output gun_border_en,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the right place. :-)

@terminator2k2
Copy link

Hi @jotego i have used your changes in ascal.vhd and sys_top.v to add a menu osd item for the sinden boarders to enable/disable the boarder in some mister console cores and it works really nice. So to make life easier for sinden users would it be ok to try to push these changes into mister-devel ? (just making sure you would be ok with this first as its your changes) I could then do PR's for the seperate console cores to add these in to the osd menu. Ive also created mgl files for these console cores so they can have separate cfg files. Thanks once again for your work.

@jotego
Copy link
Owner

jotego commented Mar 11, 2025

Thanks a lot for pushing this into the main sys, @terminator2k2. That makes a lot of sense. I see the PR here

The status bit used for the OSD is the one thing I need to check that is compatible with the ones we are using. Our usage list is here. We have not chosen a value for the sinden yet, but it should fit in the available ones.

Please @rp-jt have a look at the PR too.

@real-amano
Copy link

real-amano commented Mar 12, 2025

Well, I guess that was a "no" from Sorgelig.

@rp-jt rp-jt requested a review from jotego March 18, 2025 17:10
@rp-jt rp-jt requested a review from jotego March 21, 2025 10:30
@jotego jotego merged commit 3c2e9af into master Mar 21, 2025
25 of 30 checks passed
@rp-jt rp-jt deleted the sinden branch March 21, 2025 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants