Polish iconography #4391
Polish iconography #4391
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mark-tate
force-pushed
the
polish-iconography
branch
2 times, most recently
from
4bd1536
to
8344a36
Compare
|
@amritadesmet how do we feel about splitting into two pages ? |
mark-tate
force-pushed
the
polish-iconography
branch
from
8344a36
to
c625fd2
Compare
mark-tate
force-pushed
the
polish-iconography
branch
from
c625fd2
to
b5dedaf
Compare
|
@mark-tate Happy with splitting this - looks good to me now! |
| }, [filteredSymbols, deferredSearch]); | ||
|
|
||
| return ( | ||
| <Suspense fallback="Loading..."> |
There was a problem hiding this comment.
Apart from fixing lint, this takes quite long to load, do you want a different / better loading message ? e.g. using the spinner component?
| key={countryCode} | ||
| > | ||
| <LazyCountrySymbol code={countryCode} size={1} /> | ||
| <Text>{countryCode}</Text> |
There was a problem hiding this comment.
Since looking, do you feel this needs to be bolder?
origami-z
force-pushed
the
polish-iconography
branch
from
1d1d5cc
to
ed679e7
Compare
- split into 2 pages, icons and country symbols, to aid readability - added filters to icon preview, so you can show/hide solid/outline icons - aligned the country symbol preview component with the icon preview (clear button etc, no results view)
origami-z
force-pushed
the
polish-iconography
branch
from
ed679e7
to
72e7a20
Compare
| layout: DetailTechnical | ||
| --- | ||
|
|
||
| Country symbols represent a specific country and are used in contexts where geographical identification is necessary. They can be considered icons that are visually representative of a country or inter-governmental organisation. All flags are available in both circle and rectangle shapes. |
There was a problem hiding this comment.
Do we want to use the term flags?
|
|
||
| <Image | ||
| src="/img/foundations/iconography-countrysymbols-variant.png" | ||
| alt="Example of circular flag next to rectangular flag" |
There was a problem hiding this comment.
Are they symbols or flags
There was a problem hiding this comment.
Good point thanks, changed it!
There was a problem hiding this comment.
@amritadesmet There are other references to flag
There was a problem hiding this comment.
Changed the alt text.
No description provided.