Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jsk_recognition_utils] use try to import chainer depend modules #2565

Merged

Conversation

knorth55
Copy link
Member

use try to import chainer depending modules.
this PR solves jsk-ros-pkg/jsk_visualization#800

cc. @Naoki-Hiraoka

@Naoki-Hiraoka
Copy link
Contributor

In additon to chainer, I found that jsk_recognition_utils/chainermodels also depends on
fcn

@pazeshun
Copy link
Contributor

pazeshun commented Jan 13, 2021

I also found jsk_recognition_utils.datasets depends on chainercv:

from chainercv.chainer_experimental.datasets.sliceable import GetterDataset

I think it is troublesome to list all required packages in the printing message, so how about Please install chainer<7.0.0 and execute "rosdep install jsk_recognition_utils" to import jsk_recognition_utils.chainermodels and datasets?

@knorth55
Copy link
Member Author

@pazeshun I update this branch. I found that chainer, chainercv and fcn are chainer depending packages, so I check these 3 packages. How about this?

@pazeshun
Copy link
Contributor

@knorth55 Oh, thank you for your hard work!
After this change, we have to change jsk_recognition_utils/__init__.py as well as package.xml when new dependency is added to chainermodels or datasets.
Is this OK for you?

@knorth55
Copy link
Member Author

@pazeshun yes, probably it is ok.
also all chainer problems will be solved when all robots use noetic + python3...

@k-okada k-okada merged commit 040e5a4 into jsk-ros-pkg:master Jan 26, 2021
@knorth55 knorth55 deleted the jsk-recognition-utils-chainer-import branch January 26, 2021 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants