Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing ros_environment dependency to package.xml #2837

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

kjeremy
Copy link
Contributor

@kjeremy kjeremy commented May 9, 2024

Any package that evaluates ROS_VERSION, ROS_DISTRO or ROS_PYTHON_VERSION at build time should add ros_environment as a dependency.

Any package that evaluates ROS_VERSION, ROS_DISTRO or ROS_PYTHON_VERSION
at build time should add ros_environment as a dependency.
@kjeremy kjeremy force-pushed the add-missing-ros_environment branch from c83db37 to ea7296c Compare May 14, 2024 13:51
Copy link
Member

@iory iory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any package that evaluates ROS_VERSION, ROS_DISTRO or ROS_PYTHON_VERSION at build time should add ros_environment as a dependency.

Given this, shouldn't we also include ros_environment as a dependency in packages like checkerboard_detector and resized_image_transport?

@k-okada k-okada merged commit a3283f8 into jsk-ros-pkg:master Oct 29, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants