Skip to content

Fixing the Navigation is not working in the blog in Japanese #1642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Deepak-cell311
Copy link

@Deepak-cell311 Deepak-cell311 commented May 11, 2025

Closes #1614

What kind of change does this PR introduce?

This PR fixes a bug where in-page navigation (e.g., table of contents or anchor links) was not working in the Japanese version of the blog. The root cause was that the slugifyMarkdownHeadline function did not correctly handle non-Latin characters like Japanese, resulting in empty or malformed slugs.

Checklist

  • I have linked a related issue using Closes #1614
  • I have described the kind of change made
  • I have tested the feature in both English and Japanese blog versions
  • I have ensured slugs generate correctly for Unicode characters
  • I have verified anchor links are working as expected

@benjagm

@Deepak-cell311 Deepak-cell311 requested a review from a team as a code owner May 11, 2025 18:02
Copy link

Hi @Deepak-cell311! Thanks a lot for your contribution!

I noticed that the following required information is missing or incomplete: issue reference, kind of change description

Please update the PR description to include this information. You can find placeholders in the PR template for these items.

Thanks a lot!

Copy link

github-actions bot commented May 11, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview a67c7b1

Copy link

codecov bot commented May 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b68db4b) to head (a67c7b1).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1642   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          396       396           
  Branches       106       106           
=========================================
  Hits           396       396           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Deepak-cell311
Copy link
Author

Hi @DhairyaMajmudar ,
Kindly have a look over and review this PR whenever you have a moment.
Thank you🚀

@benjagm
Copy link
Collaborator

benjagm commented Jun 14, 2025

@AQIB-NAWAB can you please review this PR instead of opening a new one?

@Utkarsh-123github Utkarsh-123github moved this from Unclear to Ready to review in PR - Triage Group Jun 16, 2025
@AQIB-NAWAB
Copy link
Contributor

Sure @benjagm

@benjagm
Copy link
Collaborator

benjagm commented Jun 28, 2025

@Utkarsh-123github can you please help me reviewing this PR?

@benjagm benjagm self-requested a review June 28, 2025 14:26
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why changes are made in this file? This file isn't related to the issue.

Copy link
Member

@Utkarsh-123github Utkarsh-123github left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Deepak-cell311 , the changes which you made in pages/community/index.page.tsx file isn't related to this issue. Kindly update the PR by removing those code changes in that particular file.
Thank you!

@Utkarsh-123github
Copy link
Member

Also @Deepak-cell311 , a small but helpful tip for you, before raising a new PR please checkout to the main branch, perform a git pull and then create a new branch. I think the extra code changes in your PRs might have come from creating the new branch off of a different branch instead of main. Hope this helps! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Changes requested
Development

Successfully merging this pull request may close these issues.

🐛 Bug: Navigatoin is not working in the blog in Japanese
4 participants