-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI Enhancements: Account creation + config file change #64
Merged
alanmarkoTrilitech
merged 7 commits into
main
from
alan@cli_enhancements/account_create
Oct 24, 2023
Merged
CLI Enhancements: Account creation + config file change #64
alanmarkoTrilitech
merged 7 commits into
main
from
alan@cli_enhancements/account_create
Oct 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanmarkoTrilitech
changed the title
Account creation + config file change
CLI Enhancements: Account creation + config file change
Oct 23, 2023
johnyob
requested changes
Oct 24, 2023
johnyob
requested changes
Oct 24, 2023
johnyob
force-pushed
the
alan@cli_enhancements/account_create
branch
from
October 24, 2023 16:50
40d680f
to
f4531a0
Compare
johnyob
approved these changes
Oct 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
https://app.asana.com/0/1205170694555856/1205670949626065/f
Description
This PR enables account creation using
jstz account create command
command based on the passphrase provided. If none is provided a random one is generated. It saves the created account to a list in the config file.Manually testing the PR
cargo run -- account create bob
cargo run -- account create bob --passphrase greatpassphrase