Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI Enhancements: Account creation + config file change #64

Merged
merged 7 commits into from
Oct 24, 2023

Conversation

alanmarkoTrilitech
Copy link
Collaborator

@alanmarkoTrilitech alanmarkoTrilitech commented Oct 23, 2023

Context

https://app.asana.com/0/1205170694555856/1205670949626065/f

Description

This PR enables account creation using jstz account create command command based on the passphrase provided. If none is provided a random one is generated. It saves the created account to a list in the config file.

Manually testing the PR

cargo run -- account create bob
cargo run -- account create bob --passphrase greatpassphrase

@alanmarkoTrilitech alanmarkoTrilitech changed the title Account creation + config file change CLI Enhancements: Account creation + config file change Oct 23, 2023
jstz_cli/src/accounts/account_list.rs Outdated Show resolved Hide resolved
jstz_cli/src/accounts/account.rs Outdated Show resolved Hide resolved
jstz_cli/src/accounts/account_management.rs Outdated Show resolved Hide resolved
jstz_cli/src/accounts/account_management.rs Outdated Show resolved Hide resolved
jstz_cli/src/accounts/account_management.rs Outdated Show resolved Hide resolved
jstz_cli/src/accounts/account.rs Outdated Show resolved Hide resolved
jstz_cli/src/accounts/account.rs Outdated Show resolved Hide resolved
jstz_cli/src/accounts/mod.rs Outdated Show resolved Hide resolved
jstz_cli/src/config.rs Outdated Show resolved Hide resolved
jstz_cli/src/accounts/account.rs Outdated Show resolved Hide resolved
jstz_cli/src/accounts/account.rs Outdated Show resolved Hide resolved
jstz_cli/src/main.rs Outdated Show resolved Hide resolved
@johnyob johnyob force-pushed the alan@cli_enhancements/account_create branch from 40d680f to f4531a0 Compare October 24, 2023 16:50
Copy link
Collaborator

@johnyob johnyob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alanmarkoTrilitech alanmarkoTrilitech merged commit 8802555 into main Oct 24, 2023
5 checks passed
@alanmarkoTrilitech alanmarkoTrilitech deleted the alan@cli_enhancements/account_create branch October 24, 2023 17:53
@johnyob johnyob mentioned this pull request Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants