[wip] Add completion configurer

.gitignore

@@ -113,6 +113,6 @@ atest/output/
 junit.xml
 coverage/
 .vscode/
-_schema.d.ts
+_*.d.ts
 _build
 .virtual_documents/

atest/05_Features/Completion.robot

@@ -128,35 +128,38 @@ Material Theme Works
     Trigger Completer
     Capture Page Screenshot    02-completions-shown.png
     # TabError is a builtin exception which is a class in Python,
-    # so we should get lsp:material-class-light icon:
+    # so we should get lsp:material-themed-class icon:
     Completer Should Suggest    TabError
-    Completer Should Include Icon    lsp:material-class-light
+    Completer Should Include Icon    lsp:material-themed-class
+    [Teardown]    Reset Plugin Settings    plugin id=${COMPLETION PLUGIN ID}
 
-VSCode Theme Works
-    Configure JupyterLab Plugin    {"theme": "vscode"}    plugin id=${COMPLETION PLUGIN ID}
+VSCode Unthemed Works
+    Configure JupyterLab Plugin    {"theme": "vscode", "colorScheme": "unthemed"}    plugin id=${COMPLETION PLUGIN ID}
     Capture Page Screenshot    01-configured.png
     Enter Cell Editor    1    line=2
     Trigger Completer
     Capture Page Screenshot    02-completions-shown.png
     Completer Should Suggest    TabError
-    Completer Should Include Icon    lsp:vscode-class-light
+    Completer Should Include Icon    lsp:vscode-unthemed-class
+    [Teardown]    Reset Plugin Settings    plugin id=${COMPLETION PLUGIN ID}
 
-VSCode Dark Theme Works
+VSCode Muted Works
     ${file} =    Set Variable    Completion.ipynb
     Lab Command    Use JupyterLab Dark Theme
     Wait For Splash
     Capture Page Screenshot    00-theme-changed.png
-    Configure JupyterLab Plugin    {"theme": "vscode"}    plugin id=${COMPLETION PLUGIN ID}
+    Configure JupyterLab Plugin    {"theme": "vscode", "colorScheme": "muted"}    plugin id=${COMPLETION PLUGIN ID}
     Capture Page Screenshot    01-configured.png
     Open ${file} in ${MENU NOTEBOOK}
     Enter Cell Editor    1    line=2
     Wait Until Fully Initialized
     Trigger Completer
     Capture Page Screenshot    02-completions-shown.png
     Completer Should Suggest    TabError
-    Completer Should Include Icon    lsp:vscode-class-dark
+    Completer Should Include Icon    lsp:vscode-muted-class
     Lab Command    Use JupyterLab Light Theme
     Wait For Splash
+    [Teardown]    Reset Plugin Settings    plugin id=${COMPLETION PLUGIN ID}
 
 Works Without A Theme
     Configure JupyterLab Plugin    {"theme": null}    plugin id=${COMPLETION PLUGIN ID}
@@ -166,6 +169,7 @@ Works Without A Theme
     Capture Page Screenshot    02-completions-shown.png
     Completer Should Suggest    TabError
     Wait Until Page Contains Element    ${COMPLETER_BOX} .jp-Completer-monogram
+    [Teardown]    Reset Plugin Settings    plugin id=${COMPLETION PLUGIN ID}
 
 Works With Incorrect Theme
     Configure JupyterLab Plugin    {"theme": "a-non-existing-theme"}    plugin id=${COMPLETION PLUGIN ID}
@@ -175,6 +179,7 @@ Works With Incorrect Theme
     Capture Page Screenshot    02-completions-shown.png
     Completer Should Suggest    TabError
     Wait Until Page Contains Element    ${COMPLETER_BOX} .jp-Completer-monogram
+    [Teardown]    Reset Plugin Settings    plugin id=${COMPLETION PLUGIN ID}
 
 *** Keywords ***
 Setup Completion Test

atest/Keywords.robot

@@ -4,6 +4,7 @@ Library           SeleniumLibrary
 Library           OperatingSystem
 Library           Process
 Library           String
+Library           ./logcheck.py
 Library           ./ports.py
 
 *** Keywords ***
@@ -70,12 +71,10 @@ Tear Down Everything
     Terminate All Processes    kill=${True}
 
 Lab Log Should Not Contain Known Error Messages
-    ${log} =    Get File    ${LAB LOG}
-    ${test log} =    Set Variable    ${log[${PREVIOUS LAB LOG LENGTH}:]}
-    ${length} =    Get Length    ${log}
-    Set Global Variable    ${PREVIOUS LAB LOG LENGTH}    ${length}
-    Run Keyword If    ("${OS}", "${PY}") !\= ("Windows", "36")
-    ...    Should Not Contain Any    ${test log}    @{KNOWN BAD ERRORS}
+    Touch    ${LAB LOG}
+    ${length} =    Get File Size    ${LAB LOG}
+    File Should Not Contain Phrases    ${LAB LOG}    ${PREVIOUS LAB LOG LENGTH}    @{KNOWN BAD ERRORS}
+    [Teardown]    Set Global Variable    ${PREVIOUS LAB LOG LENGTH}    ${length}
 
 Wait For Splash
     Go To    ${URL}lab?reset&token=${TOKEN}

atest/logcheck.py

@@ -0,0 +1,24 @@
+import os
+
+from bs4 import UnicodeDammit
+
+
+def file_should_not_contain_phrases(filename, offset=0, *phrases):
+    """don't fail _too_ hard if the file can't be read for soem reason"""
+    with open(filename, "rb") as fp:
+        raw = fp.read()[offset:]
+
+    text = None
+
+    try:
+        text = raw.decode("utf-8")
+    except Exception as err:
+        text = UnicodeDammit.detwingle(raw).decode("utf-8")
+
+    matches = {}
+
+    for phrase in phrases:
+        if phrase in text:
+            matches[phrase] = True
+
+    assert not matches, "Phrases found in {}: {}".format(filename, matches)

atest/ports.py

@@ -4,9 +4,9 @@
 
 
 def get_unused_port():
-    """ Get an unused port by trying to listen to any random port.
+    """Get an unused port by trying to listen to any random port.
 
-        Probably could introduce race conditions if inside a tight loop.
+    Probably could introduce race conditions if inside a tight loop.
     """
     sock = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
     sock.bind(("localhost", 0))

ci/env-test.yml.in

@@ -33,7 +33,8 @@ dependencies:
   - pytest-runner
   - ruamel_yaml
   # browser testing
+  - bs4
   - firefox
   - geckodriver
-  - robotframework-seleniumlibrary
   - robotframework >=3.2
+  - robotframework-seleniumlibrary

docs/Language Servers.ipynb

@@ -42,6 +42,7 @@
     "\n",
     "import IPython\n",
     "from jinja2 import Template\n",
+    "\n",
     "from jupyter_lsp import LanguageServerManager"
    ]
   },

docs/conf.py

@@ -102,7 +102,6 @@
 
 
 def setup(app):
-    """ Runs before the "normal business" of sphinx. Don't go too crazy here.
-    """
+    """Runs before the "normal business" of sphinx. Don't go too crazy here."""
     app.add_css_file("css/custom.css")
     subprocess.check_call(["jlpm", "--ignore-optional"])

packages/completion-theme/package.json

@@ -33,10 +33,11 @@
     "lab:link": "jupyter labextension link . --no-build"
   },
   "devDependencies": {
-    "react": "*",
-    "@jupyterlab/ui-components": "~2.2.0"
+    "react": "*"
+  },
+  "peerDependencies": {
+    "react": "*"
   },
-  "peerDependencies": {},
   "jupyterlab": {
     "extension": true,
     "schemaDir": "schema"