refactor: cleanup no longer needed old chart test config #1710
+10
−80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manics
reviewed
May 30, 2023
| @@ -1,8 +1,5 @@ | |||
| # This config is used when both BinderHub and the JupyterHub it uses are | |||
| # deployed to a kubernetes cluster. | |||
| # note: when changing the config schema, | |||
| # the old version of this file may need to be copied to ./binderhub-chart-config-old.yaml | |||
| # before updating, and then deleted in a subsequent PR. | |||
There was a problem hiding this comment.
How will future schema breaks be handled?
There was a problem hiding this comment.
I'd probably want to adopt something like done in z2jh, which is to add specific overrides via --set if needed, like in here.
There was a problem hiding this comment.
Marking this as draft to think a bit further about this.
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.