refactor: cleanup no longer needed old chart test config

.github/workflows/diff.yml

@@ -48,20 +48,14 @@ jobs:
 
           # NOTE: We change the directory so binderhub the chart name won't be
           #       misunderstood as the local folder name.
-          # validation is disabled, because the config is for a different version!
+          #
+          #       https://github.com/helm/helm/issues/9244
+          #
           cd testing
 
-          old_config="../testing/k8s-binder-k8s-hub/binderhub-chart-config-old.yaml"
-          if [ -f "$old_config" ]; then
-            echo "using old config"
-          else
-            old_config="../testing/k8s-binder-k8s-hub/binderhub-chart-config.yaml"
-          fi
-
           helm install binderhub-test binderhub \
-              --values "$old_config" \
-              --repo https://jupyterhub.github.io/helm-chart/ \
-              --disable-openapi-validation \
+              --values=../testing/k8s-binder-k8s-hub/binderhub-chart-config.yaml \
+              --repo=https://jupyterhub.github.io/helm-chart/ \
               --version=$UPGRADE_FROM_VERSION
 
       - name: "Helm diff latest released dev chart with local chart"

.github/workflows/test.yml

@@ -249,24 +249,17 @@ jobs:
           echo ""
           echo "Installing already released binderhub version $UPGRADE_FROM_VERSION"
 
-          # FIXME: We change the directory so binderhub the chart name won't be
-          #        misunderstood as the local folder name.
+          # NOTE: We change the directory so binderhub the chart name won't be
+          #       misunderstood as the local folder name.
+          #
+          #       https://github.com/helm/helm/issues/9244
           #
-          #        https://github.com/helm/helm/issues/9244
           cd ci
 
-          old_config="../testing/k8s-binder-k8s-hub/binderhub-chart-config-old.yaml"
-          if [ -f "$old_config" ]; then
-            echo "using old config"
-          else
-            old_config="../testing/k8s-binder-k8s-hub/binderhub-chart-config.yaml"
-          fi
-
           helm install binderhub-test \
               --repo https://jupyterhub.github.io/helm-chart/ binderhub \
-              --disable-openapi-validation \
               --version=$UPGRADE_FROM_VERSION \
-              --values "$old_config" \
+              --values=../testing/k8s-binder-k8s-hub/binderhub-chart-config.yaml \
               --set config.BinderHub.hub_url=http://localhost:30902 \
               --set config.BinderHub.hub_url_local=http://proxy-public \
               --set config.GitHubRepoProvider.access_token=$GITHUB_ACCESS_TOKEN \

testing/k8s-binder-k8s-hub/binderhub-chart-config.yaml

@@ -1,8 +1,5 @@
 # This config is used when both BinderHub and the JupyterHub it uses are
 # deployed to a kubernetes cluster.
-# note: when changing the config schema,
-# the old version of this file may need to be copied to ./binderhub-chart-config-old.yaml
-# before updating, and then deleted in a subsequent PR.
 
 service:
   type: NodePort