Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

local-binder-local-hub: Set min versions in requirements #1748

Merged

Conversation

manics
Copy link
Member

@manics manics commented Sep 24, 2023

NullAuthenticator is replaced by the built-in null.

I've set minimum versions of the requirements to more closely reflect what's we're likely to test locally.

jupyter-repo2docker
jupyterhub
nullauthenticator
dockerspawner>=12
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first version that's greater than 0.x.x

jupyterhub
nullauthenticator
dockerspawner>=12
jupyter-repo2docker>=2023.06.0
Copy link
Member Author

@manics manics Sep 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Older versions will fail on some R repos since MRAN no longer works.
https://repo2docker.readthedocs.io/en/latest/changelog.html#breaking-changes

@consideRatio consideRatio merged commit cc192d3 into jupyterhub:main Sep 25, 2023
13 checks passed
@consideRatio consideRatio added the maintenance Under the hood improvements and fixes label Sep 25, 2023
@manics manics deleted the local-binder-local-hub-requirements branch September 25, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Under the hood improvements and fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants