Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

local-binder-local-hub: Set min versions in requirements #1748

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion testing/local-binder-local-hub/jupyterhub_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ class LocalContainerSpawner(BinderSpawnerMixin, DockerSpawner):

c.Application.log_level = "DEBUG"
c.Spawner.debug = True
c.JupyterHub.authenticator_class = "nullauthenticator.NullAuthenticator"
c.JupyterHub.authenticator_class = "null"

c.JupyterHub.hub_ip = "0.0.0.0"
c.JupyterHub.hub_connect_ip = hostip
Expand Down
7 changes: 3 additions & 4 deletions testing/local-binder-local-hub/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
dockerspawner
jupyter-repo2docker
jupyterhub
nullauthenticator
dockerspawner>=12
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first version that's greater than 0.x.x

jupyter-repo2docker>=2023.06.0
Copy link
Member Author

@manics manics Sep 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Older versions will fail on some R repos since MRAN no longer works.
https://repo2docker.readthedocs.io/en/latest/changelog.html#breaking-changes

jupyterhub>=3