Move allowed_groups and admin_groups to base authenticator #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A simplification of jupyterhub#735, moving 2 of the 3 traitlets. This is a straight up move, without any functional breaking changes. - `admin_groups` allows setting members of some groups as admins. - `allowed_groups` allows setting what groups should be allowed to login. Both of these are more useful with claim_groups_key, as that allows an *external* party to drive group memberships. Without that, I guess primarily this depends on membership within the JupyterHub admin UI. Splitting this up helps us get this moving faster, as figuring out how to move `claim_groups_key` is going to be slightly more involved.
for more information, see https://pre-commit.ci
|
I was wrong, looks like it's not actually easier to move just these two - I thought |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simplification of #735, moving 2 of the 3 traitlets. This is a straight up move, without any functional breaking changes.
admin_groupsallows setting members of some groups as admins.allowed_groupsallows setting what groups should be allowed to login.Both of these are more useful with claim_groups_key, as that allows an external party to drive group memberships. Without that, I guess primarily this depends on membership within the JupyterHub admin UI.
Splitting this up helps us get this moving faster, as figuring out how to move
claim_groups_keyis going to be slightly more involved.