Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move allowed_groups and admin_groups to base authenticator #741

Closed
wants to merge 2 commits into from
Closed

Move allowed_groups and admin_groups to base authenticator #741

wants to merge 2 commits into from

Commits on Apr 25, 2024

  1. Move allowed_groups and admin_groups to base authenticator 

    A simplification of jupyterhub#735,
moving 2 of the 3 traitlets. This is a straight up move, without any functional
breaking changes.

- `admin_groups` allows setting members of some groups as admins.
- `allowed_groups` allows setting what groups should be allowed to login.

Both of these are more useful with claim_groups_key, as that allows
an *external* party to drive group memberships. Without that, I guess
primarily this depends on membership within the JupyterHub admin UI.

Splitting this up helps us get this moving faster, as figuring out how
to move `claim_groups_key` is going to be slightly more involved.
    @yuvipanda
    yuvipanda committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    63f6642 View commit details
    Browse the repository at this point in the history

  2. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    4283e14 View commit details
    Browse the repository at this point in the history