Re-install conda/mamba for every tljh upgrade (doesn't imply upgrade) #968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a simplification to help ensure we don't run into issues like below because requests gets installed via pip. ``` RemoveError: 'requests' is a dependency of conda and cannot be removed from conda's operating environment. ```
This can help us check if a package has been installed from PyPI via pip, or from conda-forge or other channel via conda/mamba.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have previously re-installed (without upgrading) conda and mamba, and done it based on specific versions. I think we are required to do this uncodntionally though. I think based conda/conda#12366 (comment) that since tljh make use of both pip and conda/mamba to install packages via plugins, even though we mostly use pip, we must do this re-install to ensure conda/mamba is functional before an tljh upgrade.
I think we end up with
requestsinstalled via pip during the initial setup of tljh, and that sets us up for issues when we are to make an upgrade later when conda/mamba is being used via plugins. I think the reason we didn't have this error before in tests, but do now, relates to new versions ofopensslhave been released, and that conda/mamba automatically upgrades them.