Skip to content
This repository has been archived by the owner on Jan 30, 2024. It is now read-only.

[backend] Fix #167 #171 #168

Merged
merged 6 commits into from
Jan 10, 2024
Merged

Conversation

Error0229
Copy link
Contributor

@Error0229 Error0229 commented Jan 10, 2024

Trickly Resolves #167
Fix #169 Fix #171

Changes

  • Add constraint for table, so adding coupon when the shop would cause 500 Internal server error
  • Use transaction to disable shop's product when the set shop enabled == false
  • Remove O."status" in admin's report query

Testing Approach (if unconventional)

Disable a user's shop, creating a coupon will cause Internal Server Error
Disable a user's shop, its all products should be disabled.
Buy something and process the order status to any status. Admin report would consider the order success.

@Error0229 Error0229 self-assigned this Jan 10, 2024
@UGisBusy UGisBusy mentioned this pull request Jan 10, 2024
8 tasks
@Error0229 Error0229 linked an issue Jan 10, 2024 that may be closed by this pull request
@Error0229 Error0229 changed the title [backend] add coupon constraint [backend] Fix #167 #169 Jan 10, 2024
Copy link
Contributor

@kryr34 kryr34 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM w/o test

@Error0229 Error0229 merged commit 034b02a into jykuo-love-shiritori:main Jan 10, 2024
4 checks passed
@kryr34 kryr34 changed the title [backend] Fix #167 #169 [backend] Fix #167 #171 Jan 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants