-
Notifications
You must be signed in to change notification settings - Fork 7
Conversation
this will need to fix after #168 merged |
fix where |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
u didnt refactor any error message, there're many grammar error
if u wont fix it in this pr, pls dont link it and checked it.
if you don't have time to complete your work, there's no need to hastily submit incomplete work |
the work i mentioned here are all complete so i open the pr to let you check. |
can u split #157 into another pr? |
my bad |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Resolves
some of
#160
#162
#163
Changes
some of
Test Environment Setup
open 3 terminals
one for
docker-compose up postgres minio
one for
go run .
one for
cd frontend
->npm i
->npm run build
then open the browser then enter http://localhost:8080/
Additional context
N / A