Skip to content
This repository has been archived by the owner on Jan 30, 2024. It is now read-only.

[frontend] Improve #169

Merged
merged 9 commits into from
Jan 10, 2024
Merged

Conversation

KatoToyoki
Copy link
Contributor

@KatoToyoki KatoToyoki commented Jan 10, 2024

Resolves
some of
#160
#162
#163

Changes

some of

Test Environment Setup

open 3 terminals
one for docker-compose up postgres minio
one for go run .
one for cd frontend -> npm i -> npm run build
then open the browser then enter http://localhost:8080/

Additional context

N / A

@UGisBusy
Copy link
Collaborator

this will need to fix after #168 merged
( backend will not return 200 when it failed

@kryr34
Copy link
Contributor

kryr34 commented Jan 10, 2024

can #157 #160 be separated into 2 other PR?
and please list detail change about what some of #162 #163 #164

@KatoToyoki
Copy link
Contributor Author

KatoToyoki commented Jan 10, 2024

this will need to fix after #168 merged ( backend will not return 200 when it failed

fix where
i add all patch, post, delete 500 detection

@KatoToyoki
Copy link
Contributor Author

KatoToyoki commented Jan 10, 2024

can #157 #160 be separated into 2 other PR? and please list detail change about what some of #162 #163 #164

i have no time tonight i said several times thanks, but i can move issue detail to here
edit : here i use improper word, my bad

Copy link
Collaborator

@UGisBusy UGisBusy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#164

u didnt refactor any error message, there're many grammar error
if u wont fix it in this pr, pls dont link it and checked it.

@KatoToyoki
Copy link
Contributor Author

#164

u didnt refactor any error message, there're many grammar error if u wont fix it in this pr, pls dont link it and checked it.

what but i use suggestion code of @kryr34 and the alert is also updated? i ask chatGPT to correct the grammer.
can you point out where is not changed?

@kryr34
Copy link
Contributor

kryr34 commented Jan 10, 2024

i have no time tonight i said several times thanks, but i can move issue detail to here

if you don't have time to complete your work, there's no need to hastily submit incomplete work

@KatoToyoki
Copy link
Contributor Author

KatoToyoki commented Jan 10, 2024

i have no time tonight i said several times thanks, but i can move issue detail to here

if you don't have time to complete your work, there's no need to hastily submit incomplete work

the work i mentioned here are all complete so i open the pr to let you check.
when i fix products, @UGisBusy said i can also modify coupons.
or where do you think it's hastily submit, please point out.

@UGisBusy
Copy link
Collaborator

UGisBusy commented Jan 10, 2024

can u split #157 into another pr?
that one might cause bugs and need to be tested cautiously while others just some minor fix.

Error0229 added a commit that referenced this pull request Jan 10, 2024
@kryr34
Copy link
Contributor

kryr34 commented Jan 10, 2024

my bad

@kryr34 kryr34 reopened this Jan 10, 2024
Copy link
Contributor

@Error0229 Error0229 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@UGisBusy UGisBusy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@UGisBusy UGisBusy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@KatoToyoki KatoToyoki merged commit 9634486 into jykuo-love-shiritori:main Jan 10, 2024
4 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve product pages UX blocking when shop disable Remove unused asset, JSON
5 participants