Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactoring to the new schema #1219

Merged
merged 6 commits into from
Aug 15, 2024
Merged

feat: refactoring to the new schema #1219

merged 6 commits into from
Aug 15, 2024

Conversation

AlexsJones
Copy link
Member

❯ grpcurl -plaintext  localhost:8080 list 
grpc.reflection.v1.ServerReflection
grpc.reflection.v1alpha.ServerReflection
schema.v1.ServerAnalyzerService
schema.v1.ServerConfigService

This PR is pinned against buf.build remote schema update to this version

✅ Checks

  • [ x] My pull request adheres to the code style of this project
  • [x ] My code requires changes to the documentation
  • [x ] I have updated the documentation as required
  • [x ] All the tests have passed

ℹ Additional Information

@AlexsJones AlexsJones requested review from a team as code owners August 7, 2024 15:12
@AlexsJones
Copy link
Member Author

related operator changes

Copy link
Contributor

@matthisholleville matthisholleville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work ! Left 1 comment/suggestion and the linter report 2 failure checks

pkg/custom/client.go Show resolved Hide resolved
@AlexsJones
Copy link
Member Author

Great work ! Left 1 comment/suggestion and the linter report 2 failure checks

Thanks, update

Copy link
Contributor

@JuHyung-Son JuHyung-Son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AlexsJones AlexsJones merged commit 02fa109 into main Aug 15, 2024
10 checks passed
@AlexsJones AlexsJones deleted the feat/schema-refactor branch August 15, 2024 13:42
ronaldpetty pushed a commit to ronaldpetty/k8sgpt that referenced this pull request Aug 17, 2024
* feat: refactoring to the new schema

Signed-off-by: AlexsJones <[email protected]>

* chore: updated readme with grpc commands

Signed-off-by: AlexsJones <[email protected]>

* chore: updated deps

Signed-off-by: AlexsJones <[email protected]>

---------

Signed-off-by: AlexsJones <[email protected]>
Co-authored-by: Matthis <[email protected]>
AlexsJones added a commit that referenced this pull request Oct 24, 2024
* feat: refactoring to the new schema

Signed-off-by: AlexsJones <[email protected]>

* chore: updated readme with grpc commands

Signed-off-by: AlexsJones <[email protected]>

* chore: updated deps

Signed-off-by: AlexsJones <[email protected]>

---------

Signed-off-by: AlexsJones <[email protected]>
Co-authored-by: Matthis <[email protected]>
Signed-off-by: AlexsJones <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants