Add GetDefaultPkeyFromPci and GetPKeyByIndexFromPci functions #69
Conversation
sriovnet.go
Outdated
| @@ -520,3 +520,32 @@ func GetPciFromNetDevice(name string) (string, error) { | |||
| } | |||
| return base, nil | |||
| } | |||
|
|
|||
| // GetPKeyFromPci returns the index0 PKey for the IB PCI device | |||
| func GetPKeyFromPci(pciAddress string) (string, error) { | |||
There was a problem hiding this comment.
this works for both PF and VFs ? (just making sure, my memory is dusty around these parts :D)
There was a problem hiding this comment.
there are several indexes for pkey membership, index0 is the default membership.
should we have two functions ?
func GetPkeyByIndexFromPci(pciAddress string) (string, error)
and
func GetDefaultlPkeyFromPci(pciAddress string) (string, error
There was a problem hiding this comment.
This works for both PFs and VFs as the mechanism around how PKeys are stored is the same for both.
I'm not opposed having two functions to retrieve different PKeys. Let me address that in the PR
There was a problem hiding this comment.
Split into two new functions
almaslennikov
force-pushed
the
get-pkey
branch
from
988e8b5
to
4f978d0
Compare
almaslennikov
changed the title
|
@bn222 PTAL, quick one :) |
almaslennikov
force-pushed
the
get-pkey
branch
from
4f978d0
to
e886cd2
Compare
|
Hi @bn222, thank you for the review! addressed your comments. |
The functions read the from the PCI device's infiniband dir and returns either the PKey for index0 or given index Signed-off-by: amaslennikov <[email protected]>
almaslennikov
force-pushed
the
get-pkey
branch
from
e886cd2
to
11b7b17
Compare
|
LGTM. |
The functions read the from the PCI device's
infiniband dir and returns either the PKey for index0 or given index