-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add annotations #23
Add annotations #23
Conversation
*/ | ||
String id(); | ||
/** | ||
* Index of field in sequence of fields in the type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Index of an attribute in sequence of attributes in the type."?
*/ | ||
int index(); | ||
/** | ||
* Documentation string, that attached to the field in {@code doc} language element. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style/grammar: "Documentation string attached to the attribute, specified in doc
KSY element"?
One minor note: how can I build my branches? http://doc.kaitai.io/developers.html recommends checkout https://github.com/kaitai-io/kaitai_struct, but there will not be my changes, because they are in my fork of submodule projects (https://github.com/Mingun/kaitai_struct_java_runtime and https://github.com/Mingun/kaitai_struct_compiler). Also, how to create a stage build and run tests? |
c92781f
to
dc5d595
Compare
"kaitai_struct", being what we call "an umbrella project", is essentially just an empty git repo which is used to bring all other repos in some pre-set directory layout to your machine. You can easily clone https://github.com/kaitai-io/kaitai_struct, and then replace contents of Once that's done, basically what you do is:
|
Thank you for your explanations! Later I systemize my experience and send a PR to |
So what the status of this? |
Overall, it seems solid and useful. However, the devil is in the details:
For now, let's go ahead with what we have. I'll try to formalize the terms in future. |
Thanks! |
Runtime changes for kaitai-io/kaitai_struct_compiler#191