Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add annotations #23

Merged
merged 1 commit into from
Jan 22, 2020
Merged

Add annotations #23

merged 1 commit into from
Jan 22, 2020

Conversation

Mingun
Copy link
Contributor

@Mingun Mingun commented Jan 11, 2020

*/
String id();
/**
* Index of field in sequence of fields in the type
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Index of an attribute in sequence of attributes in the type."?

*/
int index();
/**
* Documentation string, that attached to the field in {@code doc} language element.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/grammar: "Documentation string attached to the attribute, specified in doc KSY element"?

@Mingun
Copy link
Contributor Author

Mingun commented Jan 13, 2020

One minor note: how can I build my branches? http://doc.kaitai.io/developers.html recommends checkout https://github.com/kaitai-io/kaitai_struct, but there will not be my changes, because they are in my fork of submodule projects (https://github.com/Mingun/kaitai_struct_java_runtime and https://github.com/Mingun/kaitai_struct_compiler). Also, how to create a stage build and run tests?

@Mingun Mingun force-pushed the annotations branch 2 times, most recently from c92781f to dc5d595 Compare January 13, 2020 19:24
@GreyCat
Copy link
Member

GreyCat commented Jan 13, 2020

One minor note: how can I build my branches? http://doc.kaitai.io/developers.html recommends checkout https://github.com/kaitai-io/kaitai_struct, but there will not be my changes, because they are in my fork of submodule projects (https://github.com/Mingun/kaitai_struct_java_runtime and https://github.com/Mingun/kaitai_struct_compiler). Also, how to create a stage build and run tests?

"kaitai_struct", being what we call "an umbrella project", is essentially just an empty git repo which is used to bring all other repos in some pre-set directory layout to your machine.

You can easily clone https://github.com/kaitai-io/kaitai_struct, and then replace contents of compiler/ with https://github.com/Mingun/kaitai_struct_compiler and runtime/java/ with https://github.com/Mingun/kaitai_struct_java_runtime. That will give you the very same environment, but with your changes.

Once that's done, basically what you do is:

  • tests/build-compiler to build the compiler
  • tests/build-formats to convert all test .ksy formats into all target languages (including Java), which will give you tests/compiled/java
  • tests/run-java will run all the tests for Java; results will be in tests/test_out/java

@Mingun
Copy link
Contributor Author

Mingun commented Jan 14, 2020

Thank you for your explanations! Later I systemize my experience and send a PR to doc repository with instructions, how to work on project.

@Mingun
Copy link
Contributor Author

Mingun commented Jan 19, 2020

So what the status of this?

@GreyCat
Copy link
Member

GreyCat commented Jan 22, 2020

Overall, it seems solid and useful. However, the devil is in the details:

  • Documentation strings need major overhaul for grammar and brevity.
  • We might want to review the terminology.

For now, let's go ahead with what we have. I'll try to formalize the terms in future.

@GreyCat GreyCat merged commit 141e84e into kaitai-io:master Jan 22, 2020
@Mingun
Copy link
Contributor Author

Mingun commented Jan 22, 2020

Thanks!

@Mingun Mingun deleted the annotations branch January 22, 2020 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants