-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate annotations for Java classes #191
base: master
Are you sure you want to change the base?
Conversation
3ddcd37
to
425b1bb
Compare
I finish work on the feature. Now
PR with adds annotations to runtime -- kaitai-io/kaitai_struct_java_runtime#23. I wasn't ran tests with |
I would be happy to see it merged, as it will allow to proceed the improvement of |
@GreyCat, can you look at this? I didn't miss anything? |
Can this be merged before another conflict occurred? There is no point in having support for annotation in the runtime without their support in the compiler |
@GreyCat , please do not bury the project. Can you give feedback for my PRs? |
Hi! Apologies for super late response. This PR changes a lot, and I'm not 100% with you in certain aspects of it. I'll try to highlight main points of concern. |
shared/src/main/scala/io/kaitai/struct/languages/JavaCompiler.scala
Outdated
Show resolved
Hide resolved
shared/src/main/scala/io/kaitai/struct/languages/JavaCompiler.scala
Outdated
Show resolved
Hide resolved
shared/src/main/scala/io/kaitai/struct/languages/JavaCompiler.scala
Outdated
Show resolved
Hide resolved
shared/src/main/scala/io/kaitai/struct/languages/PHPCompiler.scala
Outdated
Show resolved
Hide resolved
I've took liberty to resolve the conflict which arisen due to recent changes. Please pull it first if you'll be contributing more stuff on top of this branch? |
Actually, I plan to make a rebase to keep history linear as much as possible |
I fully rework implementation:
Because that includes also changes in runtime, I try to make PR for main repository: kaitai-io/kaitai_struct#801. But as it my first experience with submodules PR, I don't know will it success or not. Therefore, if PR to the main repository fails to marge, tell me about it. Generated file
|
6fe9f28
to
696e5d7
Compare
Proposal for kaitai-io/kaitai_struct_java_runtime#22. Annotations make it much easier to create a visualizer, especially, if input for visualizer is class, derived from kaitai-generated class and if kaitai-io/kaitai_struct#672 will be implemented.
Right now I want to see, if it compiles and also receive some review comments.