Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't need channel_id in activity body, and causes mass-assignment error in kandan #11

Merged
merged 1 commit into from
Oct 19, 2024

Conversation

JangoSteve
Copy link
Contributor

Our Hubot was broken after we updated kandan. The kanan activities controller now scopes activities automatically to the channel id directly from the channel_id parameter. So the nested activity[:channel_id] parameter is no longer needed, and actually causes a mass-assignment error, causing hubot's post to fail.

@JangoSteve
Copy link
Contributor Author

I should also mention that I submitted this update separately here:
kandanapp/hubot-kandan#12

But I had to make the change directly also in this project, because the hubot-kandan module, where this change was made, is required indirectly as a dependency of the direct hubot-kandan-heroku module dependency in this app, but that module no longer exists on Github, so there's no way to update that dependency to point to the updated hubot-kandan dependency.

If you check out the hubot-kandan-heroku npm module, you'll notice that its Github repo no longer exists.

@fusion94 fusion94 merged commit 0fd426d into kandanapp:master Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants