virtual chain from block batching.
#454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coderofstuff
requested changes
Sep 18, 2024
There was a problem hiding this comment.
Notes
- Based on discussions, the intent is that this RPC API should work with a default behavior even if
startHashis not specified. In such a case, startHash will become the pruning point automatically.
Changes
- Add this RPC call in
cli/src/modules/rpc.rs - On
rpc/core/wasm/message.rs:- update the IGetVirtualChanFromBlockRequest interface so that startHash is nullable.
- Update the try_from accordingly such that if
startHashis not set, it defaults to zero hash
| let mut removed = Vec::new(); | ||
| let mut common_ancestor = from; | ||
| for current in self.reachability_service.default_backward_chain_iterator(from) { | ||
| for current in self.reachability_service.default_backward_chain_iterator(from).take(max_traversal_allowed) { |
There was a problem hiding this comment.
This iteration would start from block at from + max_traversal_allowed and go back all the way to from correct?
There was a problem hiding this comment.
well technically it is more like starting at from, and going back at most max_traversal_allows (the break condition is in the loop).
…chain ancestor of high.
…kaspa into vspcc_batch_call
coderofstuff
previously approved these changes
Sep 19, 2024
coderofstuff
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes virtual chain from block and acceptance data batching possibilities in consensus; via a
limitparameter. new consensus api is exposed to the corresponding vspc rpc call, which will implictly batch bymergeset_size_limit * 10amount of chain blocks, ifinclude_trainsactions = false, elsemergeset_size_limit * 10amount of merged blocks (via further processing).It also exposes get_virtual_chain_from_block in cli.
Note: this change needs to be clearly communicated and documented to external kaspa integrators, who are using this call, as changes are implicit, and not circumventable, any integrator that assumes a full virtual chain to the current virtual parent, and relies on this behavior, for whatever reason, may experience issues with their integration. Although old versions will still have this behavior.
Resolves #440
(also adds some log level changes for mempool, and a version bump to 0.15.2 on the side)