Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre commit check #103

Merged
merged 7 commits into from
Jul 23, 2024
Merged

Pre commit check #103

merged 7 commits into from
Jul 23, 2024

Conversation

kazewong
Copy link
Owner

Resolving an issue with pre-commit in

jim/src/jimgw/single_event/likelihood.py

Line 710 in 2a51d8c

log_likelihood += logsumexp(log_i0_abs_fft) - jnp.log(len(tc_array))

thomasckng and others added 3 commits July 23, 2024 13:33
@thomasckng
Remove unused variable
85ddbe9
@kazewong
Fixing pre-commit issue.
a73759f 
Before this commit, typechecker has issue with the logsumexp input type at line 710.
The reason is @jit return a wrapped type, which does not match logsumexp.
Removing @jit in log_i0 in utils.py resolve this issue.
In general, util functions should not be jitted until needed during runtime
@kazewong
Removing @jit in utils function
2f0b1ae
@kazewong kazewong requested a review from thomasckng July 23, 2024 20:18
thomasckng
thomasckng approved these changes Jul 23, 2024
View reviewed changes
Copy link
Collaborator

@thomasckng thomasckng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@kazewong kazewong merged commit 204f681 into main Jul 23, 2024
4 checks passed
@kazewong kazewong deleted the pre-commit-check branch July 23, 2024 20:35
@thomasckng thomasckng mentioned this pull request Jul 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasckng thomasckng thomasckng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kazewong @thomasckng