-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow skip scaled object creation with config #795
feat: allow skip scaled object creation with config #795
Conversation
I think that this is a nice feature and simplifies the compatibility between KEDA and the HTTP add-on because avoid the requirement of implementing the whole ScaledObject spec in the add-on. WDYT @tomkerkhove @t0rr3sp3dr0 ? @frankliu20 , Could you add an e2e test for testing this feature? IMO this requires an update in docs to explain that this can be done for other users |
Signed-off-by: Frank Liu <[email protected]>
78923b0
to
2809adb
Compare
I like the idea but would rather have this as a field in the HTTPSO definition instead of an Operator argument. That way, you could have some services using the managed SO while others use a custom one. |
@frankliu20 , any update? |
Hi, any updates on that feature? I would like to use zero scaling feature, but for that I need a combination of a keda built-in trigger and the http trigger, at the moment its not possible. |
It looks that the PR has been abandoned by the OP :( |
@JorTurFer tbh no, just wanted to ask if there are any updates |
@JorTurFer Hi, I'm happy to pick this up and raise a new PR for this as I've already made the required changes for this feature on our forked repo. |
I've opened up new PR to allow annotation to be set on the HTTPSO instead as this allows more flexibility. |
This feature is already done by #929 |
When integrate Keda-Http with other KEDA scalers, we want to manage
ScaledObject
by ourselves, and add http-scaler as one of the triggers. In this PR, we allow users to do suchScaledObject
management. When flagSKIP_SCALED_OBJECT_CREATION
is set totrue
, keda-http-operator will skip theScaledObject
creation.Checklist
README.md
docs/
directory