Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataCatalog]: Lazy dataset loading #4270
[DataCatalog]: Lazy dataset loading #4270
Changes from 43 commits
7c794f4
208a24b
7c6729a
9d5b37d
c3229c0
6c509d9
bd878c9
68010aa
29d373f
e90cfd7
3f1dbe0
892cda4
e7f2632
429ca13
3ffd538
681d3f1
8177ddc
379f3b4
9335578
26d0c84
dea5630
0da806f
b813408
c63ece6
01f9b62
069dff4
15df0f8
da669f5
3999913
c50cad4
f2861ed
df5807c
eecf23a
128e79c
3b475aa
32dc417
72c106b
870b794
e031f8a
9d0f579
5f6ef85
6d23b4d
c31c5eb
822e206
1f14ded
25aebce
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we sure we'd like to expose
_LazyDataset
to the users? If yes, then maybe we need to make it a properLazyDataset
that can be instantiated even outside of the catalog. Otherwise, I'd prefer for us to hide it from this method signature.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't want to expose it and we added it here only until we use the old
add()
method for compatibility with the old catalog. I will go after the breaking change as setter will be used instead.