Fixed some issues

[prashantsengar]

Added deletion counter to fix issue #9
Added image for empty state to fix issue #6
Added preview for text files to fix a few things in issue #1

[jancborchardt]

Cool stuff @prashantsengar! :) Could you add screenshots so I can confirm it looks on my side as intended?

It also makes it easier to review for others and to see what changed. :)

[prashantsengar]

@jancborchardt sure.
Here is the screenshot showing Sweep counter and the thumbnail of a text file.

Here is a screenshot showing an empty state

[jancborchardt]

Cool, thanks for the screenshot! :)

So the sweep counter is too present. What we do in the Twitter version of Keep or Sweep is just have a counter below the "Sweep" label, inside the button. It shows nothing when it’s 0, and then just counts up. And unlike the "Sweep" label it’s not bold, and possibly 50% opacity only.

Would that be possible?

[jancborchardt]

Here’s a screenshot of the counter in the Twitter version:

And here’s the emptycontent of the Twitter version. It shows a summary of how much you swept, and also prompts you to refresh to sweep more (we don’t need the log out button for desktop of course. :):

[prashantsengar]

I will have to check for the Sweep counter. I also wanted to do something similar but since we are using an image as the button, it would be difficult to do something like that.

For the Empty state, we can just change the image named 'clean.png' in the Images directory. If you would like me to create something for that, I would do that surely

[jancborchardt]

I will have to check for the Sweep counter. I also wanted to do something similar but since we are using an image as the button, it would be difficult to do something like that.

Cool, thanks! :) Yeah, so the 🚫 is some unicode symbol, the button text is still actual text. It’s not a fully image for the button. :)

For the Empty state, we can just change the image named 'clean.png' in the Images directory. If you would like me to create something for that, I would do that surely

Would it also be possible to not use an image but rather text? That will look way better cross-platform, be more accessible and futureproof an all resolutions too. :)

[prashantsengar]

Would it also be possible to not use an image but rather text?

Okay. I would try doing that

[jancborchardt]

@prashantsengar any update on this? Is there a way I can help? :) Maybe it also helps splitting up the pull request, as the only thing with issues seems to be the counter?

[prashantsengar]

Yes @jancborchardt I was having some issues with the alignment of the text and buttons. That's a problem with tkinter, I guess. Then I had to work on other things. I will surely try to finish it off within a few days.
Any other thing that you would like me to do?

[prashantsengar]

And yes we should spilt the pull requests

[prashantsengar]

Hi @jancborchardt , I found a solution for the sweep counter and it is a bit 'hacky'. Here is the screenshot. Let me know if this works. I am trying to make the sweep button and counter a little more good looking, but I guess that's the most one can get with tkinter.

[jancborchardt]

@prashantsengar that actually looks quite good! Can we line up the "Sweep" text and icon though that it keeps at the same position it was before? So only add the counter below it, but don’t change the position of the existing content? :)

[prashantsengar]

@jancborchardt Yes I needed your help in this.
I tried a few things to do this:

1. I tried adding the counter value in the Sweep element itself like 'Sweep\n1'. The problem that it has is that I cannot have different font styles for them. They will be either both bold or normal text.

2. This approach is what you are seeing here. I created a new element just below the sweep element and that's what is causing the text alignment to be different.

Can you help me in how to go about this?