Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for nested types to CecilAssembly. #54

Closed
wants to merge 2 commits into from
Closed

Add support for nested types to CecilAssembly. #54

wants to merge 2 commits into from

Conversation

grokys
Copy link
Collaborator

@grokys grokys commented Jan 13, 2022

Adds support for nested types specified with a + to the Cecil backend.

Fixes AvaloniaUI/Avalonia#2725.

@grokys grokys requested a review from kekekeks January 13, 2022 16:22
@grokys grokys marked this pull request as draft January 13, 2022 16:23
@grokys grokys marked this pull request as ready for review January 13, 2022 21:26
grokys added a commit to AvaloniaUI/Avalonia that referenced this pull request Jan 13, 2022
@grokys
Add support for nested types in XAML compiler.
fc67073 
Updates XamlX submodule to PR kekekeks/XamlX#54
@grokys grokys mentioned this pull request Jan 13, 2022
Closed
@maxkatz6 maxkatz6 mentioned this pull request Aug 14, 2022
Closed
@topeterk
Copy link

Hi @kekekeks , are there any issues with merging this change?
Or are you waiting for a rebase due to the github warning?

@hez2010
Copy link

hez2010 commented Apr 11, 2023

Any updates?

@nuc134r
Copy link

nuc134r commented Sep 25, 2023

This is essential feature for our localization system. All the localization consts are generated before build and accessed in XAML via nested static classes. Would be great to be able to use existing localization in Avalonia apps.

@nuc134r
Copy link

nuc134r commented Oct 4, 2023 •
edited
Loading

For everyone stumbling upon this – I have a workaround for x:Static

AvaloniaUI/Avalonia#2725 (comment)

@nuc134r nuc134r mentioned this pull request Oct 4, 2023
Closed
@jp2masa jp2masa mentioned this pull request Nov 1, 2023
Open
@workgroupengineering workgroupengineering mentioned this pull request May 2, 2024
Merged
@workgroupengineering
Copy link
Contributor

Can I continue the PR?

@kekekeks
Copy link
Owner

IIRC the original change was causing InvalidProgramException, which is why it wasn't merged.

@workgroupengineering
Copy link
Contributor

IIRC the original change was causing InvalidProgramException, which is why it wasn't merged.

Do you have a test that simulates the Exception? I tested the PR in the Sandbox of this branch and it seems to work as I expected.

@workgroupengineering workgroupengineering mentioned this pull request Jul 16, 2024
Merged
@maxkatz6 maxkatz6 closed this Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kekekeks kekekeks Awaiting requested review from kekekeks

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support nested types in DataTemplate.DataType
8 participants
@grokys @topeterk @hez2010 @nuc134r @workgroupengineering @kekekeks @maxkatz6 @danwalmsley