Update componentWillReceiveProps to shouldComponentUpdate #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync with latest lifecycles
|
Still need to build dist. Because I forgot to build. |
|
Hey, is anything blocking this PR? |
Open
|
Hey, have something to fix?? |
Pardon for a confusion. It was version mismatch on my end. |
|
I'm a bit confused, this PR hasn't been merged (and componentWillReceiveProps is still used in this package), am I correct ? |
|
I've fixed conflict! Is my PR OK? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync with latest React lifecycles.