Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Few minor issues + 1 Suggestion #610

Open
PreYem opened this issue Apr 14, 2024 · 3 comments
Open

Few minor issues + 1 Suggestion #610

PreYem opened this issue Apr 14, 2024 · 3 comments

Comments

@PreYem
Copy link

PreYem commented Apr 14, 2024

Noticed few issues with Simple Armory Website :

  • Hovering over mount icons in the mount section no longer displays brief Wowhead info about them.

  • The Fyrakk mythic mount link sends you to the mount spell on wowhead instead of the item itself.
    This is the current link : https://www.wowhead.com/spell=424484/anurelos-flames-guidance
    This is the intended link I assume : https://www.wowhead.com/item=210061/reins-of-anurelos-flames-guidance

  • The link for [Sandy Shalewing] which is a Timewalking achievement mount, sends you to an error page on wowhead, as wowhead never made an item for the mount in their database for some reason.
    It would be optimal if the link would instead send you to the mount spell instead since the item itself doesn't exist, but the spell does :
    [Sandy Shalewing] Spell : https://www.wowhead.com/spell=408654/sandy-shalewing
    I also noticed the same exact issue with the [Calescent Shalewing], which is a DF achievement mount from the [Que Zara(lek), Zara(lek)] meta achievement and there is no mount item for it on Wowhead, just a spell page, which is this :
    https://www.wowhead.com/spell=408648/calescent-shalewing

  • The character icon preview on the top right seems to be blank, which is something I noticed happening fairly recently.

Suggestion : Viewing unobtainable mounts

As the name suggest, it would be somewhat interesting to add some kind of button that can reveal old unobtainable mounts that have been permanently removed and no longer obtainable in any way shape or form (Including BMAH), such as the old black Qaraji Battle Tank, or previous Gladiator mounts, or old KSM mounts, this feature would work somewhat like this :

  • If a user looks up a character profile that has 5 unobtainable mounts collected, but 5 unobtainable mounts not collected, the collected mounts would be shown by default, like it does now and the unobtainables would be hidden by default, clicking on a special button that can be put somewhere in the page can reveal the uncollected unobtainables for the user to see, just so they can get an idea of what they missed on obtaining in the past
  • Mounts that are guarenteed to go away at a certain time, such as seasonale KSM/Glad mounts should always appear in the armory for that current season, and then be considerered unobtainable once the season is over and be hidden for any character that doesn't have it already
  • When revealing the unobtainables, those mounts would be put in their respective sections, such as the [Black Proto-Drake] being part of the Wotlk section of mounts and only showing up when a user looks up a character that has the mount, but would be revealed anyway if the feature was ever added
    I'm not sure how difficult it would be to implement this feature, but it's just a suggestion. Feel free to ignore it if it's too much of a hassle.

PS : Thank you so much for making Simple Armory for tracking wow related collections and constantly updating it for the community. Geniunely my favorite website to go to for collecting mounts!!

@PreYem PreYem changed the title Mount Hovering Few minor issues Apr 14, 2024
@PreYem PreYem changed the title Few minor issues Few minor issues + 1 Suggestion Apr 14, 2024
@SolestialDev
Copy link
Collaborator

SolestialDev commented Apr 14, 2024

  • Hovering over mount icons in the mount section no longer displays brief Wowhead info about them.

This seems to be a wowhead issue (where we get the tooltips from). Nothing we can do at this moment about this.

Will correct in next version

  • The link for [Sandy Shalewing] which is a Timewalking achievement mount, sends you to an error page on wowhead, as wowhead never made an item for the mount in their database for some reason.
    It would be optimal if the link would instead send you to the mount spell instead since the item itself doesn't exist, but the spell does :
    [Sandy Shalewing] Spell : https://www.wowhead.com/spell=408654/sandy-shalewing
    I also noticed the same exact issue with the [Calescent Shalewing], which is a DF achievement mount from the [Que Zara(lek), Zara(lek)] meta achievement and there is no mount item for it on Wowhead, just a spell page, which is this :
    https://www.wowhead.com/spell=408648/calescent-shalewing

Will update those with the correct spells in the next version.

  • The character icon preview on the top right seems to be blank, which is something I noticed happening fairly recently.

Noticed this as well, looking into atm.

Suggestion : Viewing unobtainable mounts

Yeah I'd like something like this as well, in general I'd like to have a toggle to display any type of unobtainable item whether it be mounts, pets or achievements. It's on my list of things I'd like to do eventually, as well as changing the FoS page to show obtainable FoS for completionist sake. Will start working on it sometime in the near future if nobody is against it.

Most of what you suggested is already the case though, any unobtainable glad/ksm mount is there, it just gets marked as unobtainable once it goes away. Mounts like the crusader horses or the black protodrake are listed under their correct categories if you actually have them, so revealing them with a button would be very minimal effort. See example:
image

@kevinclement
Copy link
Owner

The character icon preview on the top right seems to be blank, which is something I noticed happening fairly recently”

i looked into it yesterday. Looks like blizzard is having an issue, it’s returning 403. I tested on their API testing site and saw the same problem so it’s likely and incident on their side.

@kevinclement
Copy link
Owner

The character icon preview on the top right seems to be blank, which is something I noticed happening fairly recently”

i looked into it yesterday. Looks like blizzard is having an issue, it’s returning 403. I tested on their API testing site and saw the same problem so it’s likely and incident on their side.

Just pushed a change for this via #612 that uses a diff method for getting the avatar url.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants