Add steering file for CLD+LAr to CLDConfig #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zehvogel
requested changes
Nov 14, 2023
There was a problem hiding this comment.
This is incredibly hard to review like this, please:
- split this into multiple commits that show which parts actually changed compared to whatever steering file you started with.
- use the up to date version of CLDReconstruction.py as a basis
- remove any references to local paths e.g.
/home/ksasikum/... - remove other unused code e.g. references to
FCCDETECTORS
Comment on lines
+103
to
+112
| # if FCC_DETECTORS is empty, this should use relative path to working directory | ||
| path_to_detector = os.environ.get("FCCDETECTORS", "") | ||
| print(path_to_detector) | ||
| detectors_to_use=[ | ||
| "/home/ksasikum/Key4Hep/LAr_scripts/k4geo/FCCee/CLD/compact/CLD_o4_v05/CLD_o4_v05.xml", | ||
| #"FCCDetectors/Detector/DetFCCeeIDEA-LAr/compact/FCCee_DectEmptyMaster.xml", | ||
| #"/Detector/DetFCCeeECalInclined/compact/FCCee_ECalBarrel.xml" | ||
| ] | ||
| # prefix all xmls with path_to_detector | ||
| geoservice.detectors = [os.path.join(path_to_detector, _det) for _det in detectors_to_use] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
The steering file for CLD + LAr includes LAr digitizer for the digitization of the SimCalorimeter hits from ECALBarrel.
ENDRELEASENOTES