cmake: Overhaul downstream config to properly export version and dependencies #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmadlener
force-pushed
the
cmake-config-fixes
branch
from
7dd5f8f
to
886d57f
Compare
After the discussion at todays meeting it looks like k4FWCore handles all the things also for older podio versions, so we can keep the compatibility for now. |
tmadlener
force-pushed
the
cmake-config-fixes
branch
2 times, most recently
from
f09f222
to
eb6a2b7
Compare
jmcarcell
force-pushed
the
cmake-config-fixes
branch
from
eb6a2b7
to
f8b9dc6
Compare
jmcarcell
reviewed
Oct 7, 2024
cmake/k4FWCoreCreateConfig.cmake
Outdated
Comment on lines
1
to
12
| include(CMakePackageConfigHelpers) | ||
|
|
||
| configure_package_config_file(${PROJECT_SOURCE_DIR}/cmake/k4FWCoreConfig.cmake.in | ||
| ${PROJECT_BINARY_DIR}/k4FWCoreConfig.cmake | ||
| INSTALL_DESTINATION ${CMAKE_INSTALL_LIBDIR}/cmake/k4FWCore | ||
| PATH_VARS CMAKE_INSTALL_INCLUDEDIR CMAKE_INSTALL_LIBDIR) |
There was a problem hiding this comment.
I would put these in the main CMakeLists.txt, it's only a few more lines.
There was a problem hiding this comment.
It will become a few more once we start to also export version information properly. Since we have a usable tag already, should I add that as well?
jmcarcell
reviewed
Oct 8, 2024
CMakeLists.txt
Outdated
|
|
||
| gaudi_install(CMAKE ${PROJECT_BINARY_DIR}/k4FWCoreConfig.cmake) |
There was a problem hiding this comment.
Suggested change
| gaudi_install(CMAKE ${PROJECT_BINARY_DIR}/k4FWCoreConfig.cmake) | |
| install(FILES ${PROJECT_BINARY_DIR}/k4FWCoreConfig.cmake DESTINATION ${CMAKE_INSTALL_LIBDIR}/cmake/k4FWCore) |
It's a single cmake file, gaudi_install doesn't do anything special for us and this is clearer (and we can check that the paths here and given to configure_package_config_file match).
- Make sure all required dependencies are also detected in downstream users - Add some legacy variables
Move all downstream related config to one file
tmadlener
force-pushed
the
cmake-config-fixes
branch
from
f8b9dc6
to
cff6168
Compare
tmadlener
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
k4FWCoreConfig.cmaketo put a bit more information in thereENDRELEASENOTES
There are a few things that we could also address while we are here
1.0pre-release cycle, maybe we should start to do so (and then also propagate that information to downstream consumers)MetadataSvc(Add a metadata service and a test #215 and Fix accessing input file metadata in MetadataSvc #223), I think we need at least podio 1.0 in any case.Fixes #166