Move from Associations to Links
#128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interestingly #129 seems to happen much more regularly in CI then I can reproduce it locally |
tmadlener
force-pushed
the
mv-association-links
branch
from
088eb9b
to
f5d8af8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
Associations to the newLinks (seeEDM4hep#341)MCRecoAssociationCollectionNameoutput configuration parameter has been deprecated and is replaced byRecoMCParticleLinkCollectionName. For the time being both will keep working, but the former will be removed in one of the upcoming releases. The default configuration has been adjusted accordingly.ENDRELEASENOTES
Fixes #101 in passing by removing the offending examples.