Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to snakebids v0.12.x #100

Closed
wants to merge 1 commit into from

Conversation

kaitj
Copy link
Collaborator

@kaitj kaitj commented Feb 24, 2024

Proposed changes

DO NOT MERGE - This is currently a draft PR for testing snakebids v0.12.x

This PR makes changes for upgrading to snakebids v0.12.x, removing unnecessary config options and refactoring the run.py. as needed.

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you are unsure about any of the choices, don't hesitate to ask!

  • Changes have been tested to ensure that fix is effective or that a feature works.
  • Changes pass the unit tests
  • Code has been run through the poe quality task
  • I have included necessary documentation or comments (as necessary)
  • Any dependent changes have been merged and published

Notes

All PRs will undergo the unit testing before being reviewed. You may be requested to explain or make additional changes before the PR is accepted.

@kaitj kaitj added the maintenance Updates or improvements that do not change functionality of the code label Feb 24, 2024
- Remove standard bids-app options from config (no longer necessary)
- Refactor run.py to work with new version
@kaitj kaitj force-pushed the maint/snakebids_v0.12.x branch from 56843ad to a75e067 Compare February 24, 2024 19:57
@kaitj
Copy link
Collaborator Author

kaitj commented Mar 20, 2024

Closing as this was for testing purposes.

@kaitj kaitj closed this Mar 20, 2024
@kaitj kaitj deleted the maint/snakebids_v0.12.x branch March 20, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Updates or improvements that do not change functionality of the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant