Updates to pybids 0.18 #461
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not on pypi for some reason yet -- so points to github.. this version includes the fix for UPath
since this now results in a CRITICAL warning in snakemake
pybids had a build failure for 0.18.0
github-actions
bot
requested review from
Bradley-Karat,
mcespedes99,
myousif9 and
pvandyken
|
Thanks. There's been an issue upgrading to the new pybids, because the universal pathlib adoption messed up all the tests. I had started an update PR but haven't had time to wrap it up yet |
|
OK maybe I'll pull the relative path change out of this PR so that one can be merged (it is causing an eyesore with warnings) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The universal pathlib addition to pybids (bids-standard/pybids#1074) had a bug that was only fixed in 0.18, so this upgrades snakebids to use that version.
I also make a minor change to remove the leading ./ from relative paths created in snakebids, since snakemake now throws CRITICAL warnings when it sees this..
Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you are unsure about any of the choices, don't hesitate to ask!