Check for content-type, updated buffer handling, and better query string parse #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You based this pull on 0.2 but the latest is 0.3, could you rebase it ? also, you shouldn't change the ref in travis ci image |
| @@ -2,7 +2,7 @@ var formidable = require('formidable') | |||
|
|
|||
| module.exports = function () { | |||
| return function (request, response, next) { | |||
| if (!request.method.match(/(PUT|POST|OPTIONS)/)) { | |||
| if (!request.method.match(/(PUT|POST|OPTIONS)/) || request.headers['content-type'] == undefined) { | |||
There was a problem hiding this comment.
please use just !request.headers['content-type']
|
Okay updated per request. |
| @@ -35,4 +35,4 @@ | |||
| "should": "0.6.1", | |||
| "request": "2.9.x" | |||
| } | |||
| } | |||
|
Thanks, I will try to pull this manually and squash it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes that would need to be set back would be in the package.json update your git repo link, and the README.md for the travis status icon. Other than that this should be a better version for anyone to use.
The updated querystring parser now supports object/array syntax for form url encoded data such as:
list[]=one&list[]=2&object[first]=one&object[second]=two