-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for content-type, updated buffer handling, and better query string parse #25
Open
skliffmueller
wants to merge
13
commits into
kilianc:master
Choose a base branch
from
skliffmueller:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 9 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
19b140d
POST buffer fix for recent release of node http
db2d2fc
checks if content-type is undefined, throw next if so
69f0421
checks if content-type is undefined, throw next if so
f5e6089
querystring parser switched to more friendly object-array parsing
cd7fff7
Node version update
skliffmueller 4187d6b
Update README.md
skliffmueller 052154f
Update .travis.yml
skliffmueller 4246f10
Update package.json
skliffmueller 78be88b
Update .travis.yml
skliffmueller 9e499b5
merge of recent version
80e3bbc
Merge conflicts fixed
ac67ac1
Fixed content-type check per request
a7d7273
Minor merge typo
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
language: node_js | ||
node_js: | ||
- 0.6 | ||
- "0.10" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,22 +9,22 @@ | |
"json", | ||
"jsonp" | ||
], | ||
"version": "0.2.2", | ||
"version": "0.3.0", | ||
"repository": { | ||
"type": "git", | ||
"url": "http://github.com/kilianc/node-apiserver.git" | ||
"url": "http://github.com/skliffmueller/node-apiserver.git" | ||
}, | ||
"main": "./", | ||
"scripts": { | ||
"test": "make test" | ||
}, | ||
"engines": { | ||
"node": ">= v0.6.x" | ||
"node": ">= v0.9.x" | ||
}, | ||
"dependencies": { | ||
"json-transport": "0.1.x", | ||
"apiserver-router": "0.2.x", | ||
"buffered-request": "0.1.x", | ||
"qs": "0.6.x", | ||
"fnchain": "0.1.1", | ||
"bufferjoiner": "0.1.x", | ||
"formidable": "1.0.x", | ||
|
@@ -36,4 +36,4 @@ | |
"should": "0.6.1", | ||
"request": "2.9.x" | ||
} | ||
} | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. please remove this |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please use just
!request.headers['content-type']