Clarify DST Warsaw test #135
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanpurkhiser
commented
Oct 31, 2024
Comment on lines
+847
to
+857
| # First iteration at 02:00 UTC+2:00 | ||
| self.assertEqual( | ||
| iter.get_next(datetime), | ||
| tz.localize(datetime(2017, 10, 29, 2, 0), is_dst=True), | ||
| ) | ||
|
|
||
| # Second iteration at 02:00 UTC+1:00 | ||
| self.assertEqual( | ||
| iter.get_next(datetime), | ||
| tz.localize(datetime(2017, 10, 29, 2, 0), is_dst=False), | ||
| ) |
There was a problem hiding this comment.
This is the same as this test before
start_date = tz.localize(datetime(2017, 10, 29))
self.assertEqual(
val.replace(tzinfo=None),
tz.localize(datetime(2017, 10, 29, 2)).replace(tzinfo=None),
)
local_date = tz.localize(datetime(2017, 10, 29, 2))
val = croniter("0 * * * *", local_date).get_next(datetime)
self.assertEqual(val, tz.localize(datetime(2017, 10, 29, 3)))But I think should be more clear what the test is by using the is_dst parameter of pytz.
This is also the test that I think may not be what we actually want. Wouldn't we want this to tick back to 01:00 without DST? So we would actually tick 01:00 twice. Right now we're ticking 02:00 twice, which seems wrong
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added comments to each of the test cases to clarify what they're testing.
I'm not completely sure that the hourly DST crossover test is actually correct here, I've called that out in a
XXXcomment