Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing DDS references. #23

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Removing DDS references. #23

merged 1 commit into from
Oct 20, 2023

Conversation

mateu94
Copy link
Contributor

@mateu94 mateu94 commented Oct 19, 2023 •
edited by jira bot
Loading

@mateu94 mateu94 requested review from pablogh-2000 and a team October 19, 2023 14:10
@mateu94 mateu94 self-assigned this Oct 19, 2023
mharshe
mharshe previously approved these changes Oct 19, 2023
View reviewed changes
@mharshe
Copy link
Contributor

mharshe commented Oct 19, 2023

https://github.com/klepsydra-technologies/kpsr-build/actions/runs/6575865831/job/17863977353?pr=23#step:5:1 can you modify the worflow file to remove the mkdir build command in the same PR.

@mateu94 mateu94 force-pushed the KCE-90-Remove-DDS-from-codegen-macro-in-kpsr-build branch from 0bc1e54 to f6cfe9f Compare October 19, 2023 15:13
@mateu94 mateu94 mentioned this pull request Oct 20, 2023
Merged
@mateu94 mateu94 requested a review from mharshe October 20, 2023 06:13
@mateu94 mateu94 force-pushed the KCE-90-Remove-DDS-from-codegen-macro-in-kpsr-build branch from f6cfe9f to 38151bb Compare October 20, 2023 09:31
@mharshe mharshe marked this pull request as draft October 20, 2023 09:35
@mharshe mharshe marked this pull request as ready for review October 20, 2023 09:35
@mateu94 mateu94 merged commit 07a0d4f into main Oct 20, 2023
2 checks passed
@mateu94 mateu94 deleted the KCE-90-Remove-DDS-from-codegen-macro-in-kpsr-build branch October 20, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mharshe mharshe mharshe approved these changes

@pablogh-2000 pablogh-2000 Awaiting requested review from pablogh-2000

Assignees

@mateu94 mateu94

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mateu94 @mharshe