Skip to content
This repository has been archived by the owner on Sep 6, 2019. It is now read-only.

Update buildpack template #14

Merged
merged 1 commit into from
Jun 14, 2018
Merged

Update buildpack template #14

merged 1 commit into from
Jun 14, 2018

Conversation

dprotaso
Copy link
Member

PACK_REGISTRY_GCR isn't needed anymore

@dprotaso
Update buildpack.yaml
5d5433e 
PACK_REGISTRY_GCR isn't needed anymore
@dprotaso dprotaso changed the title Update buildpack.yaml Update buildpack template May 24, 2018
@dprotaso
Copy link
Member Author

/assign ImJasonH mattmoor

imjasonh
imjasonh approved these changes May 24, 2018
View reviewed changes
Copy link
Member

@imjasonh imjasonh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@google-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ImJasonH

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dprotaso dprotaso mentioned this pull request May 24, 2018
Merged
@dprotaso
Copy link
Member Author

dprotaso commented May 24, 2018 •
edited
Loading

curious why prow isn't merging this pr? but it did merge this one knative/serving#955

@evankanderson
Copy link
Member

@adrcunha -- it looks like we don't have Prow/tide configured for knative/build-templates.

I think we're also missing tests, which might be a pre-req for tide (just guessing)?

@adrcunha
Copy link
Contributor

Evan is right in both statements. #16 is the tracking issue, but I haven't had the time to work on it yet.

@dprotaso dprotaso mentioned this pull request Jun 13, 2018
Closed
@evankanderson evankanderson merged commit 7fbaf10 into knative:master Jun 14, 2018
@evankanderson
Copy link
Member

I hit the button manually.

@dprotaso
Copy link
Member Author

dprotaso commented Jun 14, 2018 •
edited
Loading

works for me!

@dprotaso dprotaso deleted the patch-1 branch June 14, 2018 20:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@imjasonh imjasonh imjasonh approved these changes

Assignees

@imjasonh imjasonh

@mattmoor mattmoor

Labels
approved lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dprotaso @google-prow-robot @evankanderson @adrcunha @imjasonh @mattmoor