Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update buildpack template #955

Merged
merged 1 commit into from
May 24, 2018
Merged

Update buildpack template #955

merged 1 commit into from
May 24, 2018

Conversation

dprotaso
Copy link
Member

PACK_REGISTRY_GCR is no longer needed

@dprotaso
Update buildpack.yaml
fd7d02f 
PACK_REGISTRY_GCR is no longer needed
@google-prow-robot google-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 24, 2018
@dprotaso dprotaso changed the title Update buildpack.yaml Update buildpack template May 24, 2018
@dprotaso
Copy link
Member Author

dprotaso commented May 24, 2018 •
edited
Loading

/assign mattmoor evankanderson

@google-prow-robot
Copy link

@dprotaso: GitHub didn't allow me to assign the following users: mattmore.

Note that only elafros members and repo collaborators can be assigned.

In response to this:

/assign mattmore evankanderson

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dprotaso
Copy link
Member Author

/assign the real mattmoor

@evankanderson
Copy link
Member

/assign mattmoor

evankanderson
evankanderson approved these changes May 24, 2018
View reviewed changes
Copy link
Member

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if you want to reference the issue from the build-templates repo?

@evankanderson
Copy link
Member

/approve
/lgtm

@google-prow-robot google-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 24, 2018
@google-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-prow-robot google-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 24, 2018
@dprotaso
Copy link
Member Author

@evankanderson corresponding PR knative/build-templates#14

@google-prow-robot google-prow-robot merged commit 3234411 into knative:master May 24, 2018
@dprotaso dprotaso mentioned this pull request May 24, 2018
Merged
@dprotaso dprotaso deleted the patch-1 branch September 11, 2018 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evankanderson evankanderson evankanderson approved these changes

Assignees

@mattmoor mattmoor

@evankanderson evankanderson

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dprotaso @google-prow-robot @evankanderson @mattmoor