Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set HPA replica values when workload overrides are set #1548

Merged
merged 4 commits into from
Sep 12, 2023
Merged

set HPA replica values when workload overrides are set #1548

merged 4 commits into from
Sep 12, 2023

Conversation

ReToCode
Copy link
Member

@ReToCode ReToCode commented Aug 30, 2023 •
edited
Loading

Fixes #762

Proposed Changes

  • Set HPA minReplicas and maxReplicas when workloads.replicas overrides are present for an object with HPA
  • Uses the same behaviour as for the high-availability field
  • Moved HPA transformation logic to a common file
  • Add Eventing HPAs to hasHorizontalPodAutoscaler
  • Add HPA name mapping for Eventing HPAs that are named different to their target: getHPAName

Release Note

The operator now sets HorizontalPodAutoscaler replicas (on resources with HPAs) when workload overrides are defined.

@knative-prow knative-prow bot requested review from matzew and maximilien August 30, 2023 06:35
@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 30, 2023
@ReToCode
Copy link
Member Author

ReToCode commented Aug 30, 2023 •
edited
Loading

/assign @nak3
/assign @skonto
/assign @houshengbo

@codecov
Copy link

codecov bot commented Aug 30, 2023 •
edited
Loading

Codecov Report

Patch coverage: 68.85% and project coverage change: +0.01% 🎉

Comparison is base (3d8c3fb) 79.25% compared to head (8266b1f) 79.26%.
Report is 4 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1548      +/-   ##
==========================================
+ Coverage   79.25%   79.26%   +0.01%     
==========================================
  Files          40       41       +1     
  Lines        1822     1852      +30     
==========================================
+ Hits         1444     1468      +24     
- Misses        275      279       +4     
- Partials      103      105       +2
Files Changed Coverage Δ
pkg/reconciler/common/hpa.go 65.90% <65.90%> (ø)
pkg/reconciler/common/workload_override.go 83.03% <72.72%> (-0.95%) ⬇️
pkg/reconciler/common/ha.go 77.77% <80.00%> (+13.77%) ⬆️
pkg/reconciler/common/transformers.go 82.60% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

nak3
nak3 reviewed Aug 30, 2023
View reviewed changes
pkg/reconciler/common/workload_override.go Outdated
@@ -71,6 +75,13 @@ func OverridesTransform(overrides []base.WorkloadOverride, log *zap.SugaredLogge
ps = &job.Spec.Template
}

if u.GetKind() == "HorizontalPodAutoscaler" && u.GetName() == override.Name && override.Replicas != nil {
Copy link
Contributor

@nak3 nak3 Aug 30, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current []base.WorkloadOverride (spec.workloads) assume that it contains only Deployment, StatefulSet, and Job, so this condition does not happen.

We may able to support HPA for spec.workloads but it is weird that users need to set override.Replicas for HPA.

Copy link
Contributor

@nak3 nak3 Aug 30, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, the code assumes that Deployment name is same with HorizontalPodAutoscaler's name? If so, some components are different like https://github.com/knative/eventing/blob/dd68bd316559f3828e83d6d79bc490f7fe5723f5/config/brokers/mt-channel-broker/deployments/hpa.yaml#L18

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, AFAIK this is the current assumption of the operator. This PR just introduces the same same behaviour as for the high-availability flag. So the example for mt-channel-broker would also currently not work with high-availability set.

We probably should introduce a new concept to configure the HPAs with min+max fields anyways, but that is another story (mid to long term). So for the short term, can eventing change the name of the HPA? @matzew , @pierDipi

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the name requires some form of migration, can't we have a mapping deployment -> hpa name and use that?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can, but I'd propose to do that in a separate PR then, as it is a fix for that specific HPA.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with you from the code, but it still has a bit the assumption, as hasHorizontalPodAutoscaler would currently interfere with the eventing HPAs, so I added the mapping @pierDipi proposed. Now all three cases should be fine:

Given

  • mt-broker-ingress: replicas are not set in yaml
  • broker-ingress-hpa: 1-10

Case 1

  • high-available=1
  • no workload overrides

HighAvailabilityTransform

  • mt-broker-ingress —> skipped
  • broker-ingress-hpa —> not skipped, set to 1

OverridesTransform

  • mt-broker-ingress —> skipped
  • broker-ingress-hpa —> skipped

Case 2

  • high-available not set
  • workload overrides: mt-broker-ingress=2

HighAvailabilityTransform

  • mt-broker-ingress —> skipped
  • broker-ingress-hpa —> skipped

OverridesTransform

  • mt-broker-ingress —> set to 2
  • broker-ingress-hpa —> set to 2

Case 3

  • high-available=3
  • workload overrides: mt-broker-ingress=2

HighAvailabilityTransform

  • mt-broker-ingress —> skipped
  • broker-ingress-hpa —> not skipped, set to 3

OverridesTransform (this is executed later, as it is more specific)

  • mt-broker-ingress —> set to 2
  • broker-ingress-hpa —> set to 2

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these all covered in tests?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so, but I'll double-check.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, followup is fine as well

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these all covered in tests?

Now all those cases are covered in tests.

skonto
skonto reviewed Sep 6, 2023
View reviewed changes
pkg/reconciler/common/hpa.go Outdated Show resolved Hide resolved
skonto
skonto reviewed Sep 6, 2023
View reviewed changes
pkg/reconciler/common/hpa.go

// Increase maxReplicas to the amount that we increased,
// because we need to avoid minReplicas > maxReplicas happenning.
if err := unstructured.SetNestedField(u.Object, max+(replicas-min), "spec", "maxReplicas"); err != nil {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if we log something here for debugging reasons.

@ReToCode ReToCode force-pushed the workload-overrides-hpa branch from 7ebde50 to e3d26f1 Compare September 7, 2023 06:21
@skonto
Copy link
Contributor

skonto commented Sep 7, 2023

LGTM @houshengbo should we merge?
@ReToCode does this need any doc updates here https://knative.dev/docs/install/operator/configuring-serving-cr/#high-availability or we are good?

@ReToCode
Copy link
Member Author

ReToCode commented Sep 8, 2023

@ReToCode does this need any doc updates here https://knative.dev/docs/install/operator/configuring-serving-cr/#high-availability or we are good?

No that should be fine. This does not change anything for the high-available field.

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 8, 2023
@ReToCode ReToCode force-pushed the workload-overrides-hpa branch from bd4039c to da912d9 Compare September 8, 2023 05:15
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 8, 2023
@ReToCode
Copy link
Member Author

@houshengbo would you mind taking a look?

@ReToCode
Copy link
Member Author

/assign @houshengbo

houshengbo
houshengbo approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@houshengbo houshengbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 12, 2023
@knative-prow
Copy link

knative-prow bot commented Sep 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 12, 2023
@knative-prow knative-prow bot merged commit dc4be00 into knative:main Sep 12, 2023
@ReToCode
Copy link
Member Author

ReToCode commented Oct 2, 2023

/cherry-pick release-1.11

@knative-prow-robot knative-prow-robot mentioned this pull request Oct 2, 2023
Closed
@knative-prow-robot
Copy link
Contributor

@ReToCode: new pull request created: #1575

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ReToCode added a commit to ReToCode/operator that referenced this pull request Oct 2, 2023
@ReToCode
set HPA replica values when workload overrides are set (knative#1548)
74ff0af 
* set HPA replica values when workload overrides are set

* add mapping for HPAs that are named differently to their target

* add more test cases

* rename deployment override to workload override

(cherry picked from commit dc4be00)
@ReToCode ReToCode mentioned this pull request Oct 2, 2023
Merged
ReToCode added a commit to ReToCode/operator that referenced this pull request Oct 2, 2023
@ReToCode
set HPA replica values when workload overrides are set (knative#1548)
ccf0755 
* set HPA replica values when workload overrides are set

* add mapping for HPAs that are named differently to their target

* add more test cases

* rename deployment override to workload override

(cherry picked from commit dc4be00)
@ReToCode ReToCode mentioned this pull request Oct 2, 2023
Merged
knative-prow bot pushed a commit that referenced this pull request Oct 2, 2023
@ReToCode
[release-1.11] manual back-port of #1548 (#1576)
e70b4a6 
* set HPA replica values when workload overrides are set (#1548)

* set HPA replica values when workload overrides are set

* add mapping for HPAs that are named differently to their target

* add more test cases

* rename deployment override to workload override

(cherry picked from commit dc4be00)

* Run `hack/update-codegen.sh`
knative-prow bot pushed a commit that referenced this pull request Oct 2, 2023
@ReToCode
[release-1.10] manual back-port of #1548 (#1577)
d2e3906 
* set HPA replica values when workload overrides are set (#1548)

* set HPA replica values when workload overrides are set

* add mapping for HPAs that are named differently to their target

* add more test cases

* rename deployment override to workload override

(cherry picked from commit dc4be00)

* Run `hack/update-codegen.sh`
knative-automation added a commit to knative-automation/kn-plugin-operator that referenced this pull request Oct 12, 2023
@knative-automation
upgrade to latest dependencies
bc3620a 
bumping knative.dev/operator 3546a74...6520c34:
  > 6520c34 Fix wrongly dropped transformer (# 1580)
  > d2e3906 [release-1.10] manual back-port of knative/operator#1548  (# 1577)
  > acf0695 Cherry pick 1534 to release 1.10 (# 1539)
  > 5ed4238 [release-1.10] Update the manifests for operator 1.10 (# 1495)
  > ff7e841 /release-1.10 Update the manifests for release-1.10 (# 1464)
  > a0b5352 [release-1.10] Added the serving 1.10.1 (# 1439)
bumping golang.org/x/text 71a9c9a...f488e19:
  > f488e19 unicode/norm: fix function name on comment
  > fb697c0 cmd/gotext: actually use -dir flag
  > f3e69ed cmd/gotext: fix misbehaviors
  > ab07ad1 all: remove repetitive words
  > e503480 encoding/japanese, language: shorten very long sub-test names
  > 2df65d7 all: regenerate for Unicode 15.0.0
  > e3c038a all: prepare for Unicode 15.0.0
  > 3a7a255 internal/export/idna: make more space for mapping index
  > d61dd50 go.mod: delete repeated "indirect"
  > efb744f internal/export/idna: fix infinite loop in Go pre-1.10
  > 48e4a4a all: fix some comments
  > 9db913a go.mod: update to newer x/tools
  > 30dadde all: correct comment typos
bumping sigs.k8s.io/controller-runtime d189419...cd0058a:
  > cd0058a Merge pull request # 1952 from k8s-infra-cherrypick-robot/cherry-pick-1950-to-release-0.12
  > f561596 ✨  Bump k8s.io packages to v1.24.2 (# 1940)
  > b698f2b Provide access to admission.Request in custom validator/defaulter
  > 697e66d Merge pull request # 1931 from k8s-infra-cherrypick-robot/cherry-pick-1930-to-release-0.12
  > d15de97 Merge pull request # 1914 from k8s-infra-cherrypick-robot/cherry-pick-1897-to-release-0.12
  > 0d4500b Fix webhook write response error for broken HTTP connection
  > 160efcb Merge pull request # 1913 from k8s-infra-cherrypick-robot/cherry-pick-1910-to-release-0.12
  > 54d6a15 Allow TLS config to be entirely configured on webhook server
  > 1efdbd7 Merge pull request # 1911 from k8s-infra-cherrypick-robot/cherry-pick-1907-to-release-0.12
  > 6c84577 Fix issue with starting multiple test envs
  > 3966c67 🐛 fix loading CRDs from multiple directories in envtests (# 1905)
  > 19f8d99 bug: don't override global log in builder
  > 2f77235 🐛 Avoid nilref when copying leader election options from custom config (# 1889)
  > 26c95ad Merge pull request # 1891 from FillZpp/fix-panic-for-lazy-dynamicRESTMapper
  > 5d08242 Merge pull request # 1892 from xrstf/fix-comment
  > 04f281d Fix panic for lazy dynamicRESTMapper
  > 51159d3 Merge pull request # 1888 from xrstf/remove-ioutil
  > 1da2595 Fix comment on ListOptions
  > c7a98aa 🌱 enable errorlint and unused linters (# 1890)
  > 6688005 do not use io/ioutil anymore
  > 236ad94 Merge pull request # 1877 from isitinschi/certwatcher-add-metrics
  > 8bf49f1 Merge pull request # 1887 from alvaroaleman/update-k8s
  > 98de9ad certwatcher: add metrics to monitor certificate reads
  > c868236 Merge pull request # 1885 from xrstf/kube-1.24.0
  > 5594b70 🏃 Update k8s.io/ dependencies to 0.24.0
  > b1e1a4f ✨ Improve the fake client builder with WithObjectTracker option (# 1863)
  > 3cb6722 Merge pull request # 1880 from sbueringer/pr-bump-linters-to-1.18
  > e0694d6 fix typo
  > c162794 Merge pull request # 1873 from everettraven/feature/fake-client-delete-dry-run
  > 46ccbd3 Merge pull request # 1879 from sbueringer/pr-bump-v1.24.0-rc.1
  > 750a283 Bump linters to Go 1.18
  > 1b1516c Bump to k8s.io v1.24.0
  > da9d35c ✨ Add TransformFuncByObject Option for Informer Cache (# 1805)
  > 98d34c2 make fake client delete operations honor dry run opt
  > b9071d2 Bump to k8s.io v1.24.0-rc.1
  > eb39b8e Merge pull request # 1636 from hatfieldbrian/master
  > 954449d Merge pull request # 1864 from alexzielenski/deps-1.24
  > b8bc54a return a bool from AddFinalizer and RemoveFinalizer
  > 7937b83 Merge pull request # 1868 from alvaroaleman/update-golangci-lint
  > 3047bf4 update kubernetes to 1.24-beta
  > e52a8b1 Merge pull request # 1750 from ficoos/clean-failed-start
  > 0a4d154 Merge pull request # 1862 from damdo/pkg-envtest-komega-fix-updatestatus-godoc
  > af600b0 🏃 Update golangci-lint to 1.45.2
  > 46179a0 Merge pull request # 1753 from FillZpp/add-fillzpp-as-a-reviewer
  > 6690783 Cleanup if envtest controlplane fails to start
  > 188b486 Merge pull request # 1856 from JohnStrunk/fix-zap-test
  > bc7cc68 pkg: envtest: komega: fix godoc Succeed typos
  > f236f03 Merge pull request # 1743 from alvaroaleman/fix-passing
  > d6fb2f6 Add FillZpp as a reviewer
  > 8996162 Merge pull request # 1858 from devholic/log-get-informer
  > 3847eeb fix: zap-time-encoding test should allow negative tz offset
  > 8d9b8d5 pkg: envtest: komega: fix UpdateStatus godoc
  > 5a24475 Merge pull request # 1722 from hs0210/work
  > 558ef2e 🐛 Correctly pass cache options on
  > adc9fa9 Merge pull request # 1800 from skitt/unusable-cache-dir
  > 8aaf7d9 Log all errors from cache.GetInformer call
  > 05aa087 Merge pull request # 1851 from mars1024/dev/bruce
  > 0f4890a Merge pull request # 1741 from sbueringer/pr-kubernetes-1.23
  > 688c0de Fix a small typo
  > e3773b6 Merge pull request # 1736 from pjbgf/bump-text
  > a5708a1 Try a temporary directory if the user cache fails
  > b921952 Merge pull request # 1846 from atlassian-forks/master
  > 0ba1fc8 returned objects of reference type should be unchangeable
  > 3ffc700 Merge pull request # 1738 from hakman/k8s-1.23.0-rc.0
  > 1f06556 Upgrade to Kubernetes v1.23
  > 7e7bf8c Merge pull request # 1710 from alvaroaleman/default-selector
  > c1b5ceb Bump golang.org/x/text to v0.3.7
  > c46b410 Merge pull request # 1843 from NikhilSharmaWe/k8sDepUp
  > 7f57edc Add BaseContext to manager Options
  > 59a1a4f Update k8s.io/* dependencies to v0.23.0-rc.1
  > 8f43f26 Merge pull request # 1724 from siliconbrain/patch-1
  > 0b60488 ✨ Allow configuring a default cache selector
  > 5636d97 Merge pull request # 1837 from creydr/add-zap-time-encoding-to-doc
  > 6cd5aaf Upgrade k8s dependencies from 1.23.0 to 1.23.5
  > 067c1dc Merge pull request # 1731 from zoues/go1.17
  > 74e68b5 avoid panic by checking before dereferencing
  > c73b143 Merge pull request # 1703 from FillZpp/fix-internal-cache-object-selector
  > e42a8c1 Merge pull request # 1827 from sbueringer/pr-align-logging
  > 2f0bae4 Add docu for zap-time-encoding flag
  > 4d10a06 Merge pull request # 1716 from sgreene570/fix-signals-package-go-docs
  > 4890598 bump golang version 1.17
  > 1462c6e Merge pull request # 1698 from iawia002/comments-typo
  > fc9db3a Fix the internal cache object selector
  > 9ee63fc Merge pull request # 1767 from schrej/feature/komega
  > 598978c logging: align to Kubernetes structured logging, add reconcileID
  > 619e6b9 Merge pull request # 1714 from sbueringer/pr-upgrade-deps-alpha4
  > 11f5650 Fix SetupSignalHandler godoc
  > ffa8c50 Merge pull request # 1688 from creydr/add-time-encoding-flag
  > 2ef7e9a 📖 fix comments typo in Reconciler interface
  > eb292e5 Merge pull request # 1818 from sgreene570/fix-option-godocs
  > c19a6ed Add komega package with helpers for writing tests
  > 6c7c1d7 Merge pull request # 1695 from vincepri/runnable-group
  > 1c34c83 Bump to gomega v1.17.0, k8s.io/ v1.23-alpha4, bump setup-envtest deps
  > 4d6d8ef Merge pull request # 1687 from sbueringer/pr-improve-startup-logs
  > 5bb6cb7 Add zap-time-encoding flag
  > d887b2f Merge pull request # 1815 from haoxins/patch-1
  > 364ed9a manager.go: Fix a few Options fields' go-docs
  > 0a3dd2a Merge pull request # 1709 from varshaprasad96/bump/k8s-1.23-alpha
  > 612e9b2 🐛 Refactor manager to avoid race conditions and provide clean shutdown
  > 3e870eb 🐛  Start the Cache if the Manager has already started (# 1681)
  > b98f5f7 Improve startup logs
  > e1880f5 Merge pull request # 1683 from sbueringer/pr-fakeclient-restmapper
  > ce8bdd3 Merge pull request # 1810 from sbueringer/pr-log-panic
  > b9916c4 Fix examples typo
  > 958ff15 ⚠️ bump k8s to 1.23-alpha.3
  > 11917e9 Merge pull request # 1667 from vincepri/pointer-crds-webhooks
  > b1efff6 Merge pull request # 1678 from vincepri/runnables-retry
  > 932017a fake-client: extend builder with an option to set a RESTMapper
  > f62a0f5 🐛  Check to see if obj is nil so there is no panic trying to get the gvk (# 1807)
  > f99e395 log panic in reconcile even if panic should not be recovered
  > 8e1263d Merge pull request # 1666 from sbueringer/pr-fix-modify-conversion-webhook-panic
  > a14a68c ⚠️ Avoid shallow copies of webhooks and CRDs in testenv
  > dba3220 Merge pull request # 1676 from vincepri/admission-for
  > 4af39e6 🌱 Source should retry to get informers until timeout expires
  > b6da9c1 📖 Explain what may happen when using OnlyMetadata and Get on the concrete type instead of PartialMetadataObject (# 1747)
  > 3fb2cfd Merge pull request # 1808 from erikgb/fix/issue-1786
  > 394eaa7 Merge pull request # 1665 from sbueringer/pr-fix-envtest-webhook-wait
  > f003102 envtest: fix CRD installation
  > 13f1400 Merge pull request # 1677 from zchee/use-filepath-join
  > e133413 ✨ Allow webhooks to register custom validators/defaulter types
  > cfd9276 Merge pull request # 1813 from alam0rt/bump-prom-client-golang-module
  > 5b2eaae Merge pull request # 1806 from sbueringer/pr-controller-name-kv
  > 5ed64c9 🐛 Cache sync cancelled should not error with timeout
  > f20692b Merge pull request # 1662 from alvaroaleman/allow-save
  > 3929c84 envtest: get gvk from hook struct instead of forcing set TypeMeta
  > 1730628 Manager should use the global logger, reduce log names verbosity (# 1647)
  > 76b74e8 Merge pull request # 1674 from amurant/master
  > f5a07d8 client/config: use filepath.Join for loadingRules.Precedence
  > 183ca0f 0.11.0 -> 0.11.1
  > b5bb688 Merge pull request # 1803 from JustinKuli/leader-election-events
  > b4d1c56 Add controller-name as kv pair instead of as name
  > 5e0ef5f Merge pull request # 1664 from alvaroaleman/unconditionally-set-negotioated-serializer
  > dcd5e10 🐛 Fakeclient: Allow manipulating registered types through unstructured
  > 12df3d2 🏃 Update k8s.io/* dependencies to 0.22.1 (# 1646)
  > 0cce21b Merge pull request # 1671 from sbueringer/pr-upgrade-to-k-1.22
  > d159542 switch from rsa to ecdsa
  > 3dafc3c Merge pull request # 1797 from ashish-billore/ashish-billore-design-readme1
  > b28fa4d 🐛 Use leader config for election events
  > 386c2b5 Merge pull request # 1651 from FillZpp/fix-fake-client-patch-overwrite
  > 8100b57 🐛 Unconditionally set NegotiatedSerializer
  > 0a9a777 Construct the typed clients we need (# 1637)
  > 8f9d0df 🐛 Client: Ensure no stale data remains in target object (# 1640)
  > 669d3f2 Update k8s.io/* dependencies to 0.22.2
  > 273e608 🐛 Fixed a bug in newGVKFixupWatcher which caused the metadata informer to hang  (# 1790)
  > 331c0c1 Update design readme
  > 498ee8a Merge pull request # 1650 from joelanford/fix-partialmetadata-data-race
  > af7484e Fix object overwrite on patch for fake client
  > 4e7f0c9 Add UnsafeDisableCacheDeepCopy as list option to avoid deep copy during list (# 1274)
  > b1d9a16 Merge pull request # 1781 from timebertt/inject-and-or
  > 74ba5d7 fix: set partialmetadata gvk in list/watch funcs to avoid data race in cache
  > 5de246b Recover panic for controller reconcile and webhook handler (# 1627)
  > 7ba3e55 Merge pull request # 1773 from joelanford/feat/leader-election-use-leases-only
  > 3ed992c 🐛 Inject func in predicate.{And,Or}
  > ca01f67 Update dependencies August 2021 (# 1635)
  > f529380 Merge pull request # 1780 from kkohtaka/patch-1
  > 6c4d947 leaderelection: use 'leases' as default resource lock object
  > 45b13b9 Merge pull request # 1777 from varshaprasad96/bump/go-envtest
  > 75a1187 ✨ chore: Fix bad urls (# 1632)
  > b5a4ee7 Fix a typo
  > 19f9afe Merge pull request # 1775 from kmodules/lf
  > 2df0a5b Bump go in setup-envtest
  > 5f8befe Disable fsync on etcd envtest (# 1629)
  > b8db76e 📖 update links to godoc.org to use pkg.go.dev (# 1756)
  > b84b9bb Trim List if List GVK is provided
  > b5eeb71 ⚠ bump to kubernetes 1.22.0 (# 1626)
  > e7af185 OWNERS_ALIASES: move joelanford to maintainers (# 1624)
  > c0a5bab 🐛 Envtest should try to allocate a port for etcd listenPeerURL (# 1612)
  > 9fe547c Fix a bug with `Limit` list opt. (# 1618)
  > a4602c0 fix webhook health check tls handshake timeouts (# 1617)
  > 8fcd1ba fix the typo of certwatcher example test (# 1615)
  > 0fcaa80 🏃 Add varshaprasad96 as reviewer (# 1614)
  > 3203c07 Merge pull request # 1605 from vincepri/flock-nb
  > 3c78540 Merge pull request # 1604 from vincepri/k8s0213
  > f90348f 🐛 Use non blocking file locking for flock library
  > 8b79878 Merge pull request # 1602 from shlomitk1/namespace-restriction-from-selector
  > fccc3dd ✨ Update Kubernetes dependencies to v0.21.3
  > 865d56a Merge pull request # 1588 from sbueringer/pr-enable-webhook-started-readiness-check
  > 568672a obtain namespace for list/watch from field selectors
  > 40cffdc Merge pull request # 1597 from ashish-billore/patch-1
  > 0fd3e3f also ping the webhook server after start
  > 64b1c72 Merge pull request # 1596 from GrigoriyMikhalkin/add-godoc-badge
  > 2c00d3b Update doc.go
  > 8b8d524 make it possible to monitor if the webhook server has been started
  > 8b55f85 Update doc.go (# 1466)
  > 6c6ca4c add godoc badge to README
  > ef5c8a3 Merge pull request # 1573 from pigletfly/fix-is-namespaced
  > 5a2de70 Merge pull request # 1584 from maxg-teachable/patch-1
  > 985e819 Merge pull request # 1563 from vincepri/addr-file-based
  > 67794ff 🐛: Use objectutil isNamespaced
  > 650ea59 Merge pull request # 1587 from 2uasimojo/issues/1423/optional
  > 660a301 tmp-logging - fix markdown parsing error
  > 7d83250 Merge pull request # 1564 from vincepri/remove-async-ginkgo
  > 58c17f6 🌱 addr.Suggest should lock a file instead of memory
  > 81309dc Merge pull request # 1582 from 2uasimojo/fake-delete-ResourceVersion
  > a6ced42 ⚠️ Make `rest_client_request_latency_seconds` metric optional
  > b826f39 Merge pull request # 1567 from vincepri/disable-gotest-parallel-mac
  > 1f32e46 🌱 Remove async ginkgo tests
  > 5fb1382 ⚠️ Fakeclient: Reject Delete with mismatched ResourceVersion
  > 1e4d87c Merge pull request # 1566 from vincepri/golangci-lint-refactor
  > 47023c0 🌱 Limit parallel go test executions on MacOS
  > 44a4c03 Merge pull request # 1562 from vincepri/apiserver-no-advertise
  > c48baad Refactor golangci-lint, enable more linters and add github action
  > 484f82a Merge pull request # 1561 from vincepri/update-deps-1212
  > 0664cce 🐛 Remove advertise-address from testenv api-server
  > 719e576 Merge pull request # 1555 from DirectXMan12/infra/maintainer-emeritus-main
  > 0ba05d8 🌱 Update dependencies to Kubernetes v1.21.2
  > fbf50b0 ✨ Allow TLS minimum version to be configured (# 1548)
  > bf19298 Move directxman12 to approvers-emeritus
  > 750cf33 Merge pull request # 1481 from rashmigottipati/finalizer-library
  > a905949 Merge pull request # 1552 from DirectXMan12/docs/flags-deprecation
  > 5eb033d Address review feedback # 3
  > abb406d Merge pull request # 1551 from DirectXMan12/docs/fix-clientbuilder-ref
  > 2c1b1dd Mark all templated flag pieces as deprecated
  > 60ab6fd Split needsUpdate into two separate variables and update unit tests
  > d4ecab6 Merge pull request # 1550 from randomvariable/dependencies-06-07
  > da8716a Remove reference to ClientBuilder in Cluster docs
  > ac093b0 Address review feedback # 2
  > fca94d5 Merge pull request # 1542 from DirectXMan12/infra/add-missing-license-headers
  > 96d15b7 Update dependencies for 2021/06/07
  > b269322 Add needsUpdate and err fields on mockFinalizer struct for customizations
  > ab7825e Merge pull request # 1486 from DirectXMan12/feature/envtest-secure-port
  > 66a2e62 Make sure all files have a copyright notice
  > 9f61089 Address review comments
  > 9cbdc4a Merge pull request # 1541 from DirectXMan12/feature/testing-structured-args
  > e77a2fc Disable lll
  > c6fecbb Add unit tests
  > 72fc2c6 Merge pull request # 1540 from DirectXMan12/refactor/shuffle-internal-testing
  > ddfdfdf Testing: use structured arguments
  > 6fd12aa Ensure testing ControlPlane is restartable
  > 0a3b455 Initial commit for finalizer helper library
  > 12f94f1 🐛 filter global namespace while looking for cluster scoped resources (# 1520)
  > 294af4f Update to use new internal/testing paths
  > 3758fc6 Testing: structured arguments
  > e1a570b Expose some internal types/funcs in envtest
  > 7181f11 Merge pull request # 1504 from aayushrangwala/cleanup-webhook-setup
  > 9d53bf1 Remove last of pkg/internal/testing/integration
  > c0ca959 Tests for testing/controlplane components
  > 316aea4 Merge pull request # 1536 from vincepri/k8s0211
  > c34e747 Cleanup Webhook server setup
  > c56312c Testing: Remove legacy cruft from process
  > e8204ec Unify process.BinPathFinder with envtest's logic
  > 9f17e9a Merge pull request # 1515 from Hellcatlk/typo
  > 269337f 🌱 Update dependencies to Kubernetes v1.21.1
  > e552aee Merge pull request # 1525 from vincepri/envtest-conversion-webhook
  > 9ed51aa Testing move control plane components
  > 848bc88 Tests for TinyCA
  > 68f37ad Merge pull request # 1533 from kmodules/jp
  > bac8ae9 Fix a typo
  > ae50d4c Merge pull request # 1440 from christopherhein/tokenreview-webhook-support
  > 2bfe5cf Envtest should modify CRDs appropriately when using webhooks
  > 8622835 Split up testing/integration/internal
  > b0ed0a9 Envtest secure serving by default, 1.20 flags
  > 7863ed6 Merge pull request # 1532 from vincepri/modify-crd-registered
  > f7095b0 Update gomodules.xyz/jsonpatch/v2 v2.2.0
  > 55a329c Merge pull request # 1513 from DirectXMan12/bug/quote-envtest-tool-path
  > ce2f0c9 Merge pull request # 1523 from laverite/honor-LeaderElectionReleaseOnCancel
  > 6ae3ee1 adding TokenReview.auth.k8s.io/v1 webhook support
  > d8dd31f Merge pull request # 1531 from vincepri/bug-webhook-conversion
  > 33a6b8f 🐛 Envtest should enable conversion only for convertible GVKs
  > d63cfde Merge pull request # 1510 from alvaroaleman/add-watch
  > 066b7bb Quote path with -p env
  > 7d674fd Merge pull request # 1521 from alvaroaleman/fix-again
  > 433cc85 honor LeaderElectionReleaseOnCancel
  > fddf978 Merge pull request # 1526 from vincepri/handle-crd-webhook-unstructured
  > ce9bf3b 🐛 Envtest conversion mods should set strategy and review versions
  > c6f353f Merge pull request # 1512 from vincepri/bug-webhook-first
  > 2a2f6b4 🐛 Fakeclient: Support WithWatch
  > 745c7c9 Merge pull request # 1508 from syseleven/metadata-client-patch-options
  > 4158af1 🐛 Fakeclient: Fix List for unregistered type through unstructured
  > 8d530dd 🌱 Handle unstructured CRD objects in envtest webhook mods
  > 0c99fc7 ✨ Cache-Backed Client: Support `listOpts.Limit` (# 1479)
  > 4e548fa 🐛 Webhook servers should always start before cache syncs
  > ff44d62 metadata client applies patch options
  > a17ac06 Merge pull request # 1503 from alvaroaleman/run-unit-tests
  > 3b25aa6 🐛 fix nil Decoder in multiValidating and multiMutating handlers by implementing DecoderInjector (# 1502)
  > 9db3431 🐛 Run unittests in CI
  > 2c238de Merge pull request # 1488 from DirectXMan12/feature/envtest-setup-tool
  > 5673ada 🐛  Modify multinamespaced cache to support cluster scoped resources (# 1418)
  > 782807d Switch hack to use the new envtest tool
  > 9e04ba9 Merge pull request # 1500 from estroz/bugfix/inject-wh-server
  > 235d62a Envtest Binary Version Manager Tool
  > 485a24a Merge pull request # 1501 from kevindelgado/doc-webhook-tls
  > c51d1ca use sync.Once to initialize webhook server
  > 4aecab5 Merge pull request # 1483 from w3st3ry/envtest-darwin-arm-condition
  > e10bf72 Merge pull request # 1403 from dmvolod/issue-1392
  > d0fe020 Better document TLS requirements for webhook servers
  > f8c6ee4 pkg/manager: add Options.WebhookServer to allow external configuration of a webhook server
  > 7ef2da0 ✨ Surface API Server warnings in client (# 1468)
  > 5379eaa Add darwin arch condition for envtest script
  > 2d19f01 Merge pull request # 1484 from vincepri/wrapmetaonly
  > f0abe78 🐛 controllerutil.CreateOrPatch doesn't update not empty Status fields if Spec fields are specified
  > 2d6828d Merge pull request # 1419 from qinqon/add-cache-filter-field-option
  > 4477c71 Merge pull request # 1435 from qinqon/add-cache-filter-option-labels-and-fields
  > dac4475 🐛 Metadata objects should always preserve GroupVersionKind
  > 836b363 Merge pull request # 1391 from songminglong/patch-1
  > 442d3ca Merge pull request # 1460 from alvaroaleman/watch
  > 141ddd6 Add a design document to filter cache by selectors
  > b2c90ab Merge pull request # 1490 from kevindelgado/standalone-webhooks-fix-scheme
  > cd065bf Add SelectorsByObject option to cache
  > 2faebdb Merge pull request # 1389 from vincepri/go116-deps
  > 54c9dfb Fix namespace/Name to Namespace/Name
  > 5031262 Merge pull request # 1472 from hakman/k8s-1.21.0
  > 45aa968 ✨ Add ClientWithWatch for use in CLIs
  > 774f9d4 Merge pull request # 1414 from bboreham/newclient-comment
  > d5d2551 Merge pull request # 1429 from kevindelgado/standalone-webhooks
  > 19168b3 Actually inject the scheme in StandaloneWebhook
  > 2ad142a Merge pull request # 1341 from zhijianli88/cleanup
  > 1b47073 Update module dependencies
  > b704f44 Merge pull request # 1470 from porridge/patch-1
  > c7c85eb Update dependencies to v0.21.0
  > df2c43d Merge pull request # 1427 from alvaroaleman/fix-wait
  > 5a8400a Merge pull request # 1410 from cbandy/client-patch
  > 04e2aa4 Fix reference in comment
  > 1c186f5 Merge pull request # 1485 from estroz/docs/zap-level
  > 5a5106d fix CI
  > 0b554eb Merge pull request # 1331 from zhijianli88/internal
  > 3618bd1 testing: cleanup the temproary certs
  > ec2aeaf Update Kubernetes 1.21 deps + Go 1.16
  > 11dfabf Merge pull request # 1467 from alvaroaleman/don-require-list
  > 2d885a9 Fix doc strings for Complete() and Build().
  > 253f275 ✨ Deduplicate events before sending them into the workqueue. (# 1390)
  > aca66a0 🐛 Controller: Wait for all reconciliations before shutting down
  > 08efa13 Merge pull request # 1406 from timebertt/enh/strategic-merge-patch
  > c491478 🐛 Fix client.Apply and client.Merge to satisfy Patch
  > 7aaebcf pkg/log/zap: clarify zap level vs. logr verbosity with link to zapr explanation and test cases
  > 4dc10f9 Add examples
  > e1a725d Merge pull request # 1382 from estroz/revert/1322
  > 39740c1 🐛 internal: fix a possible temporary directory leak
  > c4870a4 testing: Call stop() to cleanup temporary directory
  > 10ae090 📖 Update godoc links (# 1450)
  > 3a037ef 🐛 Fakeclient: Do not require ListKind
  > b125a18 Merge pull request # 1421 from hakman/k8s-v1.21.0-beta.1
  > a79f6f1 ⚠️ Change client.Patch to take client.Object for performance (# 1395)
  > 9b99e55 ✨ Add client.StrategicMergeFrom
  > 9a73ff4 Update tests and docs for StandaloneServer
  > 16bf3ad Merge pull request # 1379 from vincepri/recorder-proper-stop
  > 9512597 Revert # 1322 until comprehensive removal of injection code
  > 3c5b358 Merge pull request # 1339 from alvaroaleman/wtf-lograce
  > fa42462 Merge pull request # 1451 from vincepri/lock-recorder
  > a1e2ea2 Merge pull request # 1409 from alvaroaleman/allow-new-client
  > ad4726d Update dependencies to v0.21.0-beta.1
  > eaf06ce 📖 Improve docs for manager.Options.SyncPeriod (# 1232)
  > 12c19f7 move InstrumentedHook to metrics package
  > 0247574 Merge pull request # 1372 from estroz/deps/k8s-v1.21
  > c326e7a Only cancel leader election if the runnables have shutdown
  > 0918618 Merge pull request # 1335 from varshaprasad96/bump/k8s-1.20.2
  > 2aaa357 🐛 Fix a race in the delegating logger
  > 197751d Merge pull request # 1441 from christopherhein/export-certwatcher
  > f89fe47 🐛 Event recorder should not send events when broadcaster is stopped
  > 4a8536e Merge pull request # 1302 from kevindelgado/webhook-output-scratch-env
  > aa1bfee ⚠️ Allow setting NewClientFunc w/o implementing an interface
  > 854c5e8 ⚠ Handle finalizers in the fake client (# 1399)
  > 2c24442 StandaloneWebhook can run on any arbitrary mux
  > 52d5ec7 Merge pull request # 1371 from vincepri/expose-controller-componentconfig
  > 5495ae7 deps: k8s v1.21
  > 7332f62 🐛 Fix a race condition between leader election and recorder
  > 818a2ce Merge pull request # 1332 from joelanford/fix/allow-cached-unstructured-reads
  > 3373e37  ✨ Bump k8s dependencies to 1.20.2
  > b5065bd Merge pull request # 1434 from wangxinalex/fix-typo-useexistingcluster
  > a93a723 adding certwatcher as external package
  > 09b9e84 Print webhook config options from scratch-env example
  > e388e1e Merge pull request # 1394 from alvaroaleman/fix-check
  > 85527df Merge pull request # 1408 from vincepri/v021beta0
  > 83846f5 Simple helper for unmanaged webhook server
  > a763c9a Merge pull request # 1362 from DirectXMan12/bug/channel-source
  > 82fc256 ⚠️ Support global controller options in component config
  > f527a55 Merge pull request # 1336 from christopherhein/check-everything-examples
  > eb0f1d4 pkg/client: optionally allow caching of unstructured objects
  > 17b28b4 Merge pull request # 1322 from varshaprasad96/deprecate/injectClient
  > 2a448a7 Merge pull request # 1428 from alvaroaleman/fix-cachesync
  > 87ec9b9 fix: fix the typo of `UseExistingCluster` comment
  > 5fd8414 Merge pull request # 1373 from varshaprasad96/test/waitforSync-channels
  > 29dcf23 Run verify workflow after pushes
  > bdb3f84 Merge pull request # 1400 from alvaroaleman/build-remove-restconfig
  > 4875f15 🌱 Update dependencies to v0.21.0-beta.0
  > ad730f8 Merge pull request # 1361 from alvaroaleman/more-racing
  > 3b9d201 Don't hotloop on channel source closure
  > d1a29ee Merge pull request # 1334 from christopherhein/add-request-context-func
  > df6570c checking configfile examples on check_everything.sh
  > 63e597b Merge pull request # 1326 from joelanford/bug/ignore-namespace-cluster-scoped-get
  > ea0367a Add deprecation warnings for inject interface
  > 82c68b9 Merge pull request # 1430 from alvaroaleman/deflake
  > 4d059e8 🐛 Fix cache sync timeout functionality
  > 6c8bd4c ✨ Add testcases in controller when source.Channel
  > da5d0bc Merge pull request # 1401 from alvaroaleman/fix-sa
  > 117db7d 🏃 Builder: Remove unused restconfig attribute
  > 9e78e65 Merge pull request # 1348 from croomes/stack-trace-levels
  > ab23736 ⚠️ Fix some more races in the delegating logger
  > 925c552 adding WithContextFunc for webhook server to pass info to the handler
  > fe4a67a ✨ introduce LabelChangedPredicate to trigger event on label change (# 1315)
  > 2c0bd8f feat: ignore namespace key when getting cluster-scoped resources
  > 66537ca Merge pull request # 1247 from varshaprasad96/add/cache-timeout
  > 7dc9c0f 🐛 Deflake should update CRDs if already present in the cluster
  > 1d02366 Merge pull request # 1398 from gxglls/patch-1
  > 51f0fde 🐛 Manager leader election: Don't reset restcfg UserAgent
  > 8144092 Merge pull request # 1340 from nader-ziada/fix-typo
  > 9b98559 Allow panic as an option to -zap-stacktrace-level"
  > 2750bdd Merge pull request # 1324 from joelanford/feature/init-metrics
  > 6bcef8a Merge pull request # 1320 from zhijianli88/master
  > bbfc18c Add test cases to check cache sync timeouts
  > 17a507d typo: fix typo in validatingwebhook example
  > 0133f4f Merge pull request # 1355 from rashmigottipati/fix-example
  > 1d53a12 fix var name typo
  > 73c52e8 Merge pull request # 1345 from charith-elastic/fix/source-dest-lock
  > acbdf64 feat: initialize reconciler metrics when controller is started
  > 1d63e42 Merge pull request # 1318 from varshaprasad96/bump/k8s-1.20.1
  > 010a624 Fix IntoContext() documentation
  > cdc2e0e ✨ Allow configuring cache sync timeouts
  > e1dbc44 Merge pull request # 1354 from vincepri/close-channel-after-runnables
  > 4ac2c8e Fix context.TODO() in the example
  > 25d539c 🐛 Prevent source.Channel from shutting down immediately
  > dea6dee Merge pull request # 1307 from alvaroaleman/cluster
  > a36c841 Bump k8s dependencies to 1.20.1
  > 5564be7 ✨ Fix some typos (# 1312)
  > ad68b43 Merge pull request # 1327 from alvaroaleman/start-clusters
  > c9e1c10 🐛 Manager.Elected() should beclosed after runnables are started
  > 8fde15b Merge pull request # 1309 from alvaroaleman/remove-delg
  > 066bfea ✨ Move cluster-specifics from Manager into new pkg/cluster
  > 4dad2a0 Merge pull request # 1313 from hasheddan/health-lock
  > 70df377 ✨ Manager: Start all caches before other Runnables
  > 902670f Merge pull request # 1306 from alvaroaleman/set-rv-on-create
  > ad718e3 🐛 pkg/log: Set Log to NullLogger after 30 seconds
  > cf7ac88 Merge pull request # 1299 from zlabjp/deal-with-empty-patch
  > 90035a9 Use anonymous function for locking when serving health probes
  > 51fb3f8 ⚠ Fakeclient: Set ResourceVersion when adding objects to the tracker
  > 355962a Merge pull request # 1297 from vincepri/bug-uncached-lists
  > 66972d3 Do not set PatchType if patch is empty
  > 280bb8a Merge pull request # 1268 from varshaprasad96/bump/k8s-1.20
  > 330c6e1 🐛 Cache bypass should take into account List types
  > 5720da0 Merge pull request # 1265 from coderanger/webhook-external
  > 752df70 Bump k8s dependencies to 1.20
  > 3cb27c6 ✨ Support for using both an external control plane and automatic web hooks together.
bumping golang.org/x/net 8e2b117...b225e7c:
  > b225e7c http2: limit maximum handler goroutines to MaxConcurrentStreams
  > 88194ad go.mod: update golang.org/x dependencies
  > 2b60a61 quic: fix several bugs in flow control accounting
  > 73d82ef quic: handle DATA_BLOCKED frames
  > 5d5a036 quic: handle streams moving from the data queue to the meta queue
  > 350aad2 quic: correctly extend peer's flow control window after MAX_DATA
  > 21814e7 quic: validate connection id transport parameters
  > a600b35 quic: avoid redundant MAX_DATA updates
  > ea63359 http2: check stream body is present on read timeout
  > ddd8598 quic: version negotiation
  > 3b0ab98 quic: avoid deadlock on listener close
  > 732b4bc quic: report initial TLS errors
  > 8add2e1 quic: enforce AEAD integrity limit
  > 7c40cbd dns/dnsmessage: use map[string]uint16 instead of map[string]int
  > b3f1f23 quic: initiate key updates
  > 18f2095 quic: handle peer-initiated key updates
  > 008c0af quic: refactor keys for key updates
  > 6a4de22 quic: connection lifetime management
  > ea4a2ff quic: fix detection of reserved bits in 1-RTT packets
  > 47caaff quic: send and receive UDP datagrams
  > 02eb0f3 quic: avoid deadlock when updating inbound conn-level flow control
  > 57bce0e quic: move packetType.String out of test-only code
  > cae7dab quic: outbound connection-level flow control
  > 217377b quic: inbound connection-level flow control
  > 044c308 quic: check for packet overflow when writing MAX_STREAMS
  > 5401f76 quic: test lost bidi MAX_STREAMS frame handling
  > da5f9f7 quic: don't block Writes on stream-level flow control
  > c3c6260 quic: simplify gate operations
  > 717519d quic: limits on the number of open streams
  > 94087ad dns/dnsmessage: mention that Name in non-escaped
  > 2a0da8b go.mod: update golang.org/x dependencies
  > 97384c1 quic: remove streams from the conn when done
  > 03d5e62 http2: remove unused ClientConn.tconnClosed
  > b82f062 quic: include ignored frames in test log output
  > 7374d34 quic: don't block when closing read-only streams
  > b4d09be dns/dnsmessage: compress all names while appending to a buffer
  > 8b010a5 quic: fix race condition in runAsync test helper
  > fe2abcb quic: validate stream limits in transport params
  > d1b0a97 quic: avoid sending 1-RTT frames in initial/handshake packets
  > 4332436 quic: send more transport parameters
  > 52fbe37 quic: add test helpers for acking packets
  > 4a2d37e http2: remove Docker-requiring tests
  > efb8d7a dns/dnsmessage: don't include bytes after name.Length in the compression map
  > d8d8478 quic: read-closing and reset streams, wait on close
  > 3d2be97 quic: fix testConn.uncheckedHandshake
  > 0f7767c dns/dnsmessage: validate cached section when skipping sections
  > f89417c dns/dnsmessage: reduce Parser size
  > 9cde5a0 net/http2: remove awaitGracefulShutdown
  > 95cb3bb dns/dnsmessage: show AD and CD bit in Header.GoString()
  > 126a5f3 quic: fix some bugs in the sendable stream list
  > f09e753 quic: send and receive stream data
  > 1e23797 publicsuffix: update table to version 20230804
  > c8c0290 go.mod: update golang.org/x dependencies
  > 0b21d06 quic: framework for testing blocking operations
  > 4648651 quic: add -vv flag for more verbose tests
  > 60ae793 quic: don't send session tickets
  > a7da556 http2: optimize buffer allocation in transport
  > 167593b quic: create and accept streams
  > 8ffa475 html: only render content literally in the HTML namespace
  > 63fe334 quic: gate and queue synchronization primitives
  > bd8ac9e quic: fill out connection id handling
  > 08001cc quic: debug logging of packets
  > dd0aa33 quic: tls handshake
  > 5e678bb quic: CRYPTO stream handling
  > dd5bc96 internal/quic: deflake TestConnTestConn
  > d0912d4 quic: add pipe type
  > 8db2ead quic: transport parameter encoding and decoding
  > 0adcadf quic: send and receive datagrams
  > 16cc77a quic: print better stacks on SIGQUIT
  > 4a3f925 quic: basic connection event loop
  > 57553cb quic: connection ids
  > 304cc91 quic: tracking of received packets and acks to send
  > 9475ce1 quic: fix typos in comments
  > d8f9c01 dns/dnsmessage: add fuzz test
  > 8126108 dns/dnsmessage: update Parser docs
  > a1613c2 http2: handle trailing colon in authorityAddr
  > c73c09c go.mod: update golang.org/x dependencies
  > 4fc2eb9 http2: revert Transport change from CL 486156
  > 63727cc http2: validate Host header before sending
  > 1bb09e6 quic: pass the connection ID length into 1-RTT packet parsing
  > 952fc9c quic: move ack_delay_exponent handling out of frame parsing
  > 02fe9a5 quic: loss detection
  > c8a2c5a quic: remove stray debugging print
  > 5d50b40 quic: add packetFate enum
  > ee81e8c quic: correct rttvar updates
  > ab184e6 quic: rename side type to connSide
  > 508a573 quic: add congestion controller
  > 4050002 html: handle equals sign before attribute
  > f5464dd idna: update for Unicode 15.0.0
  > 6c96ca5 go.mod: update golang.org/x dependencies
  > 5541298 quic: add packet pacer
  > 88a50b6 all: update x/sys to HEAD
  > 7e6923f quic: add RTT estimator
  > 2796e09 bpf: check for little endian CPU for OS VM comparison
  > 10cf388 quic: add a data structure for tracking lists of sent packets
  > ccc217c quic: parameterize rangeset
  > f16447c quic: add go1.21 build constraint
  > f7250ea quic: add a type tracking sent values
  > 1b5a2d8 quic: packet encoding/decoding
  > a233290 quic: add a data structure for tracking sent packets
  > 61d852e quic: error codes and types
  > d40f154 quic: varint encoding and decoding
  > 10d9069 quic: add rangeset type
  > f71a821 quic: packet protection
  > 6488c8f quic: basic packet operations
  > d4a2c13 quic: packet number encoding/decoding
  > 0d6f3cb quic: add various useful common constants and types
  > ee6956f quic: add internal/quic package
  > 6826f5a http2: close request bodies before RoundTrip error return
  > ca96da6 dns/dnsmessage: reject names with dots inside label
  > 056145c net/http: deflake TestTransportRetryAfterGOAWAY
  > abee42a http2: deflake TestTransportReuseAfterError
  > 3b31286 ipv4,ipv6: remove unneeded deadlines added for flaky tests
  > 23ce3b8 http2: disable Content-Length when nilled
  > 120fc90 http2: change default frame scheduler to round robin
  > 2b0b97d dns/dnsmessage: reject packing of 255B rooted names, reject unpacking of 256B (dns encoded) names
  > d28c0b1 all: fix some comments
  > daac0ce go.mod: update golang.org/x dependencies
  > 82780d6 http2: don't reuse connections that are experiencing errors
  > 0bfab66 ipv4, ipv6: drop redundant skip checks based on GOOS
  > 938ff15 ipv4, ipv6, nettest: skip unsupported tests on wasip1
  > eb1572c html: another shot at security doc
  > 9001ca7 nettest: re-enable unixpacket tests on netbsd/386
  > 3d5a8ee internal/socks: permit authenticating with an empty password
  > 694cff8 go.mod: update golang.org/x dependencies
  > 6960703 http2: log the correct error when retrying in (*Transport).RoundTripOpt
  > 9f24bb4 http2: properly discard data received after request/response body is closed
  > 08dda57 html: fix package doc typo
  > dfa2b5d go.mod: update golang.org/x dependencies
  > 8c4ef2f hmtl: add security section to package comment
  > 1d46ed8 html: have Render escape comments less often
  > 569fe81 html: add "Microsoft Outlook comment" tests
bumping golang.org/x/mod b3066c3...b710602:
  > b710602 sumdb/dirhash: correct documentation of hash
  > a42224d all: replace io/ioutil with io and os package
  > 77d797e sumdb/dirhash: fix a panic when argument is not a directory
  > 7c05a44 sumdb/note: remove dependency on golang.org/x/crypto/ed25519
bumping knative.dev/pkg dfad48e...df28fea:
  > df28fea Bumped x/net to v0.17.0 to fix cve-2023-44487 on release-1.10 (# 2862)

Signed-off-by: Knative Automation <[email protected]>
knative-automation added a commit to knative-automation/kn-plugin-operator that referenced this pull request Oct 12, 2023
@knative-automation
upgrade to latest dependencies
b105450 
bumping golang.org/x/sys a1a9c4b...2964e1e:
  > 2964e1e unix: remove unused readlen and writelen
  > 3186bae windows: remove the 8192-codepoint arg limit in FuzzComposeCommandLine
  > 807530f unix: remove lists of unimplemented syscalls
  > 01c413d windows: document the return type mismatch for CommandLineToArgv
  > e649453 windows: convert TestCommandLineRecomposition to a fuzz test and fix discrepancies
  > 8858c72 unix: update riscv_hwprobe constants
  > 71c9d87 windows: add console ConPTY API
  > aa9470e unix/linux: update to Linux kernel 6.5
  > c7ff727 unix: fix double copy in (*SockaddrALG).sockaddr
  > c7cbcbb unix: add TestSockaddrALG
  > 8d9dcc4 unix: modernize test helpers
  > a26c6de unix: use errnoErr in generated wrappers on solaris
  > f3ef2d1 cpu: remove the use of ioutil
  > 5a17dda unix: remove the use of ioutil
  > 38ebf41 cpu: fix wrong cache line size of riscv64
  > fdc7ef4 all: remove ioutil usage from tests
  > fc717d3 unix: remove usage of ioutil.TempFile in tests
  > cb4ecd9 unix: use filepath in tests where appropriate
  > 4848eb0 windows,windows\svc,windows\svc\mgr: use unsafe.Slice instead of unsafeheader.Slice
  > 0e97d69 all: use t.TempDir in tests
  > 0514fec unix: rm unused zos test helper functions
  > bfd1ebb unix: remove unused ptracePtr on darwin
  > 81cb935 unix, windows: use ^TestName$ regular pattern for invoking a single test
  > 5154691 unix/linux: update to gcc 13.2.0, qemu 8.0.3 for loong64 and and Go 1.21.0 for all
  > e8190d9 windows: don't check non-existent return code in GetStartupInfo
  > ad02017 windows: use SyscallN in mkwinsyscall
  > 7023367 cpu: remove repetitive word
  > eabbd5c cpu: add support for amx detection
  > 552c4e8 unix: avoid setting O_NONBLOCK needlessly by checking flags beforehand
  > ee57887 unix: add SchedSetAttr and SchedGetAttr for Linux
  > 60ecf13 windows: add TimeBeginPeriod and TimeEndPeriod syscalls
  > 104d401 unix: add riscv_hwprobe for riscv64
  > 70f4e40 unix: retry fetching of lists through sysctl if the size changes
  > ad7130c unix: add more block device ioctl numbers
  > c406141 all: fix some typos
  > 25d0004 unix: fix last argument of pselect6 on linux
  > 706fa98 windows: remove repetitive words
  > 3fead03 unix: add Mremap for netbsd
bumping golang.org/x/net c73c09c...b225e7c:
  > b225e7c http2: limit maximum handler goroutines to MaxConcurrentStreams
  > 88194ad go.mod: update golang.org/x dependencies
  > 2b60a61 quic: fix several bugs in flow control accounting
  > 73d82ef quic: handle DATA_BLOCKED frames
  > 5d5a036 quic: handle streams moving from the data queue to the meta queue
  > 350aad2 quic: correctly extend peer's flow control window after MAX_DATA
  > 21814e7 quic: validate connection id transport parameters
  > a600b35 quic: avoid redundant MAX_DATA updates
  > ea63359 http2: check stream body is present on read timeout
  > ddd8598 quic: version negotiation
  > 3b0ab98 quic: avoid deadlock on listener close
  > 732b4bc quic: report initial TLS errors
  > 8add2e1 quic: enforce AEAD integrity limit
  > 7c40cbd dns/dnsmessage: use map[string]uint16 instead of map[string]int
  > b3f1f23 quic: initiate key updates
  > 18f2095 quic: handle peer-initiated key updates
  > 008c0af quic: refactor keys for key updates
  > 6a4de22 quic: connection lifetime management
  > ea4a2ff quic: fix detection of reserved bits in 1-RTT packets
  > 47caaff quic: send and receive UDP datagrams
  > 02eb0f3 quic: avoid deadlock when updating inbound conn-level flow control
  > 57bce0e quic: move packetType.String out of test-only code
  > cae7dab quic: outbound connection-level flow control
  > 217377b quic: inbound connection-level flow control
  > 044c308 quic: check for packet overflow when writing MAX_STREAMS
  > 5401f76 quic: test lost bidi MAX_STREAMS frame handling
  > da5f9f7 quic: don't block Writes on stream-level flow control
  > c3c6260 quic: simplify gate operations
  > 717519d quic: limits on the number of open streams
  > 94087ad dns/dnsmessage: mention that Name in non-escaped
  > 2a0da8b go.mod: update golang.org/x dependencies
  > 97384c1 quic: remove streams from the conn when done
  > 03d5e62 http2: remove unused ClientConn.tconnClosed
  > b82f062 quic: include ignored frames in test log output
  > 7374d34 quic: don't block when closing read-only streams
  > b4d09be dns/dnsmessage: compress all names while appending to a buffer
  > 8b010a5 quic: fix race condition in runAsync test helper
  > fe2abcb quic: validate stream limits in transport params
  > d1b0a97 quic: avoid sending 1-RTT frames in initial/handshake packets
  > 4332436 quic: send more transport parameters
  > 52fbe37 quic: add test helpers for acking packets
  > 4a2d37e http2: remove Docker-requiring tests
  > efb8d7a dns/dnsmessage: don't include bytes after name.Length in the compression map
  > d8d8478 quic: read-closing and reset streams, wait on close
  > 3d2be97 quic: fix testConn.uncheckedHandshake
  > 0f7767c dns/dnsmessage: validate cached section when skipping sections
  > f89417c dns/dnsmessage: reduce Parser size
  > 9cde5a0 net/http2: remove awaitGracefulShutdown
  > 95cb3bb dns/dnsmessage: show AD and CD bit in Header.GoString()
  > 126a5f3 quic: fix some bugs in the sendable stream list
  > f09e753 quic: send and receive stream data
  > 1e23797 publicsuffix: update table to version 20230804
  > c8c0290 go.mod: update golang.org/x dependencies
  > 0b21d06 quic: framework for testing blocking operations
  > 4648651 quic: add -vv flag for more verbose tests
  > 60ae793 quic: don't send session tickets
  > a7da556 http2: optimize buffer allocation in transport
  > 167593b quic: create and accept streams
  > 8ffa475 html: only render content literally in the HTML namespace
  > 63fe334 quic: gate and queue synchronization primitives
  > bd8ac9e quic: fill out connection id handling
  > 08001cc quic: debug logging of packets
  > dd0aa33 quic: tls handshake
  > 5e678bb quic: CRYPTO stream handling
  > dd5bc96 internal/quic: deflake TestConnTestConn
  > d0912d4 quic: add pipe type
  > 8db2ead quic: transport parameter encoding and decoding
  > 0adcadf quic: send and receive datagrams
  > 16cc77a quic: print better stacks on SIGQUIT
  > 4a3f925 quic: basic connection event loop
  > 57553cb quic: connection ids
  > 304cc91 quic: tracking of received packets and acks to send
  > 9475ce1 quic: fix typos in comments
  > d8f9c01 dns/dnsmessage: add fuzz test
  > 8126108 dns/dnsmessage: update Parser docs
  > a1613c2 http2: handle trailing colon in authorityAddr
bumping golang.org/x/term edd9fb7...ea6303a:
  > ea6303a go.mod: update golang.org/x dependencies
  > f413282 go.mod: update golang.org/x dependencies
  > 19e73c2 go.mod: update golang.org/x dependencies
bumping knative.dev/pkg aef227e...bd99f2f:
  > bd99f2f Bumped x/net to v0.17.0 to fix cve-2023-44487 on release-1.11 (# 2860)
bumping golang.org/x/text e503480...f488e19:
  > f488e19 unicode/norm: fix function name on comment
  > fb697c0 cmd/gotext: actually use -dir flag
  > f3e69ed cmd/gotext: fix misbehaviors
  > ab07ad1 all: remove repetitive words
bumping knative.dev/operator 0575636...e70b4a6:
  > e70b4a6 [release-1.11] manual back-port of knative/operator#1548 (# 1576)
  > a957149 [release-1.11] Fixed the image overriding issue for Jobs (# 1559)
  > d481e87 [release-1.11] Update the eventing sources for 1.11 (# 1549)
  > d1386e5 Cherry pick 1534 to release 1.11 (# 1536)
  > 7ef32df [release-1.11] Update the manifests for release-1.11 (# 1514)
  > 4540ae8 Make the helm charts as a base template to scaffold the artifacts (# 1512)

Signed-off-by: Knative Automation <[email protected]>
knative-prow bot pushed a commit to knative-extensions/kn-plugin-operator that referenced this pull request Oct 19, 2023
@knative-automation
upgrade to latest dependencies (#311)
6c07127 
bumping golang.org/x/sys a1a9c4b...2964e1e:
  > 2964e1e unix: remove unused readlen and writelen
  > 3186bae windows: remove the 8192-codepoint arg limit in FuzzComposeCommandLine
  > 807530f unix: remove lists of unimplemented syscalls
  > 01c413d windows: document the return type mismatch for CommandLineToArgv
  > e649453 windows: convert TestCommandLineRecomposition to a fuzz test and fix discrepancies
  > 8858c72 unix: update riscv_hwprobe constants
  > 71c9d87 windows: add console ConPTY API
  > aa9470e unix/linux: update to Linux kernel 6.5
  > c7ff727 unix: fix double copy in (*SockaddrALG).sockaddr
  > c7cbcbb unix: add TestSockaddrALG
  > 8d9dcc4 unix: modernize test helpers
  > a26c6de unix: use errnoErr in generated wrappers on solaris
  > f3ef2d1 cpu: remove the use of ioutil
  > 5a17dda unix: remove the use of ioutil
  > 38ebf41 cpu: fix wrong cache line size of riscv64
  > fdc7ef4 all: remove ioutil usage from tests
  > fc717d3 unix: remove usage of ioutil.TempFile in tests
  > cb4ecd9 unix: use filepath in tests where appropriate
  > 4848eb0 windows,windows\svc,windows\svc\mgr: use unsafe.Slice instead of unsafeheader.Slice
  > 0e97d69 all: use t.TempDir in tests
  > 0514fec unix: rm unused zos test helper functions
  > bfd1ebb unix: remove unused ptracePtr on darwin
  > 81cb935 unix, windows: use ^TestName$ regular pattern for invoking a single test
  > 5154691 unix/linux: update to gcc 13.2.0, qemu 8.0.3 for loong64 and and Go 1.21.0 for all
  > e8190d9 windows: don't check non-existent return code in GetStartupInfo
  > ad02017 windows: use SyscallN in mkwinsyscall
  > 7023367 cpu: remove repetitive word
  > eabbd5c cpu: add support for amx detection
  > 552c4e8 unix: avoid setting O_NONBLOCK needlessly by checking flags beforehand
  > ee57887 unix: add SchedSetAttr and SchedGetAttr for Linux
  > 60ecf13 windows: add TimeBeginPeriod and TimeEndPeriod syscalls
  > 104d401 unix: add riscv_hwprobe for riscv64
  > 70f4e40 unix: retry fetching of lists through sysctl if the size changes
  > ad7130c unix: add more block device ioctl numbers
  > c406141 all: fix some typos
  > 25d0004 unix: fix last argument of pselect6 on linux
  > 706fa98 windows: remove repetitive words
  > 3fead03 unix: add Mremap for netbsd
bumping golang.org/x/net c73c09c...b225e7c:
  > b225e7c http2: limit maximum handler goroutines to MaxConcurrentStreams
  > 88194ad go.mod: update golang.org/x dependencies
  > 2b60a61 quic: fix several bugs in flow control accounting
  > 73d82ef quic: handle DATA_BLOCKED frames
  > 5d5a036 quic: handle streams moving from the data queue to the meta queue
  > 350aad2 quic: correctly extend peer's flow control window after MAX_DATA
  > 21814e7 quic: validate connection id transport parameters
  > a600b35 quic: avoid redundant MAX_DATA updates
  > ea63359 http2: check stream body is present on read timeout
  > ddd8598 quic: version negotiation
  > 3b0ab98 quic: avoid deadlock on listener close
  > 732b4bc quic: report initial TLS errors
  > 8add2e1 quic: enforce AEAD integrity limit
  > 7c40cbd dns/dnsmessage: use map[string]uint16 instead of map[string]int
  > b3f1f23 quic: initiate key updates
  > 18f2095 quic: handle peer-initiated key updates
  > 008c0af quic: refactor keys for key updates
  > 6a4de22 quic: connection lifetime management
  > ea4a2ff quic: fix detection of reserved bits in 1-RTT packets
  > 47caaff quic: send and receive UDP datagrams
  > 02eb0f3 quic: avoid deadlock when updating inbound conn-level flow control
  > 57bce0e quic: move packetType.String out of test-only code
  > cae7dab quic: outbound connection-level flow control
  > 217377b quic: inbound connection-level flow control
  > 044c308 quic: check for packet overflow when writing MAX_STREAMS
  > 5401f76 quic: test lost bidi MAX_STREAMS frame handling
  > da5f9f7 quic: don't block Writes on stream-level flow control
  > c3c6260 quic: simplify gate operations
  > 717519d quic: limits on the number of open streams
  > 94087ad dns/dnsmessage: mention that Name in non-escaped
  > 2a0da8b go.mod: update golang.org/x dependencies
  > 97384c1 quic: remove streams from the conn when done
  > 03d5e62 http2: remove unused ClientConn.tconnClosed
  > b82f062 quic: include ignored frames in test log output
  > 7374d34 quic: don't block when closing read-only streams
  > b4d09be dns/dnsmessage: compress all names while appending to a buffer
  > 8b010a5 quic: fix race condition in runAsync test helper
  > fe2abcb quic: validate stream limits in transport params
  > d1b0a97 quic: avoid sending 1-RTT frames in initial/handshake packets
  > 4332436 quic: send more transport parameters
  > 52fbe37 quic: add test helpers for acking packets
  > 4a2d37e http2: remove Docker-requiring tests
  > efb8d7a dns/dnsmessage: don't include bytes after name.Length in the compression map
  > d8d8478 quic: read-closing and reset streams, wait on close
  > 3d2be97 quic: fix testConn.uncheckedHandshake
  > 0f7767c dns/dnsmessage: validate cached section when skipping sections
  > f89417c dns/dnsmessage: reduce Parser size
  > 9cde5a0 net/http2: remove awaitGracefulShutdown
  > 95cb3bb dns/dnsmessage: show AD and CD bit in Header.GoString()
  > 126a5f3 quic: fix some bugs in the sendable stream list
  > f09e753 quic: send and receive stream data
  > 1e23797 publicsuffix: update table to version 20230804
  > c8c0290 go.mod: update golang.org/x dependencies
  > 0b21d06 quic: framework for testing blocking operations
  > 4648651 quic: add -vv flag for more verbose tests
  > 60ae793 quic: don't send session tickets
  > a7da556 http2: optimize buffer allocation in transport
  > 167593b quic: create and accept streams
  > 8ffa475 html: only render content literally in the HTML namespace
  > 63fe334 quic: gate and queue synchronization primitives
  > bd8ac9e quic: fill out connection id handling
  > 08001cc quic: debug logging of packets
  > dd0aa33 quic: tls handshake
  > 5e678bb quic: CRYPTO stream handling
  > dd5bc96 internal/quic: deflake TestConnTestConn
  > d0912d4 quic: add pipe type
  > 8db2ead quic: transport parameter encoding and decoding
  > 0adcadf quic: send and receive datagrams
  > 16cc77a quic: print better stacks on SIGQUIT
  > 4a3f925 quic: basic connection event loop
  > 57553cb quic: connection ids
  > 304cc91 quic: tracking of received packets and acks to send
  > 9475ce1 quic: fix typos in comments
  > d8f9c01 dns/dnsmessage: add fuzz test
  > 8126108 dns/dnsmessage: update Parser docs
  > a1613c2 http2: handle trailing colon in authorityAddr
bumping golang.org/x/term edd9fb7...ea6303a:
  > ea6303a go.mod: update golang.org/x dependencies
  > f413282 go.mod: update golang.org/x dependencies
  > 19e73c2 go.mod: update golang.org/x dependencies
bumping knative.dev/pkg aef227e...bd99f2f:
  > bd99f2f Bumped x/net to v0.17.0 to fix cve-2023-44487 on release-1.11 (# 2860)
bumping golang.org/x/text e503480...f488e19:
  > f488e19 unicode/norm: fix function name on comment
  > fb697c0 cmd/gotext: actually use -dir flag
  > f3e69ed cmd/gotext: fix misbehaviors
  > ab07ad1 all: remove repetitive words
bumping knative.dev/operator 0575636...e70b4a6:
  > e70b4a6 [release-1.11] manual back-port of knative/operator#1548 (# 1576)
  > a957149 [release-1.11] Fixed the image overriding issue for Jobs (# 1559)
  > d481e87 [release-1.11] Update the eventing sources for 1.11 (# 1549)
  > d1386e5 Cherry pick 1534 to release 1.11 (# 1536)
  > 7ef32df [release-1.11] Update the manifests for release-1.11 (# 1514)
  > 4540ae8 Make the helm charts as a base template to scaffold the artifacts (# 1512)

Signed-off-by: Knative Automation <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nak3 nak3 nak3 left review comments

@skonto skonto skonto left review comments

@pierDipi pierDipi pierDipi left review comments

@houshengbo houshengbo houshengbo approved these changes

@matzew matzew Awaiting requested review from matzew

@maximilien maximilien Awaiting requested review from maximilien

Assignees

@houshengbo houshengbo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

spec.deployments.replicas does not take care about HorizontalPodAutoscaler
6 participants
@ReToCode @skonto @knative-prow-robot @houshengbo @nak3 @pierDipi