Test: differential shellcheck on yaml files? #1051
Conversation
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -266,7 +266,7 @@ | |||
| unshare -Uf $UNSHARE_ARGS --keep-caps -r --map-users 1,1,65536 --map-groups 1,1,65536 -w ${SOURCE_CODE_DIR}/$CONTEXT -- buildah build \ | |||
| $VOLUME_MOUNTS \ | |||
| "${BUILDAH_ARGS[@]}" \ | |||
| "${LABELS[@]}" \ | |||
| ${LABELS[@]} \ | |||
Check failure
Code scanning / shellcheck
SC2068 Error
| @@ -31,7 +31,7 @@ | |||
|
|
|||
| if [ "$#" -ne 0 ]; then | |||
| IMAGE_WITHOUT_TAG=$(echo "$IMAGE" | sed 's/:[^:]*$//') | |||
| for tag in "$@"; do | |||
| for tag in $@; do | |||
Check failure
Code scanning / shellcheck
SC2068 Error
| @@ -197,6 +197,7 @@ | |||
| script: | | |||
| #!/usr/bin/env bash | |||
| .tekton/scripts/check-task-pipeline-bundle-repos.sh | |||
| echo "$a" | |||
Check warning
Code scanning / shellcheck
SC2154 Warning
Signed-off-by: Adam Cmiel <[email protected]>
Signed-off-by: Adam Cmiel <[email protected]>
Shouldn't report any new warnings. Signed-off-by: Adam Cmiel <[email protected]>
Shouldn't report any new warnings Signed-off-by: Adam Cmiel <[email protected]>
Will trick checkton into thinking that this file is new (but checkton will detect that it's mostly a copy of the regular buildah.yaml) This reverts commit 69c19281bf4f46ecd27342c353a6d69a52ab72a7.
These should be reported Signed-off-by: Adam Cmiel <[email protected]>
Signed-off-by: Adam Cmiel <[email protected]>
Signed-off-by: Adam Cmiel <[email protected]>
| @@ -306,7 +306,7 @@ | |||
| unshare -Uf $UNSHARE_ARGS --keep-caps -r --map-users 1,1,65536 --map-groups 1,1,65536 -w ${SOURCE_CODE_DIR}/$CONTEXT -- buildah build \ | |||
| $VOLUME_MOUNTS \ | |||
| "${BUILDAH_ARGS[@]}" \ | |||
| "${LABELS[@]}" \ | |||
| ${LABELS[@]} \ | |||
Check failure
Code scanning / shellcheck
SC2068 Error
This updats the linting workflow by adding Checkton. Checkton will review code for linting errors. Changes: * Added a step to the workflow to run Checkton. * Configured Checkton to upload the SARIF report. This implementation is based on: [konflux-ci/build-definitions#1051](konflux-ci/build-definitions#1051). Signed-off-by: Sean Conroy <[email protected]>
This updats the linting workflow by adding Checkton. Checkton will review code for linting errors. Changes: * Added a step to the workflow to run Checkton. * Configured Checkton to upload the SARIF report. This implementation is based on: konflux-ci/build-definitions#1051
This updats the linting workflow by adding Checkton. Checkton will review code for linting errors. Changes: * Added a step to the workflow to run Checkton. * Configured Checkton to upload the SARIF report. This implementation is based on: konflux-ci/build-definitions#1051 Signed-off-by: Sean Conroy <[email protected]>
This updats the linting workflow by adding Checkton. Checkton will review code for linting errors. Changes: * Added a step to the workflow to run Checkton. * Configured Checkton to upload the SARIF report. This implementation is based on: konflux-ci/build-definitions#1051 Signed-off-by: Sean Conroy <[email protected]>
Test https://github.com/chmeliik/checkton