gitops-pull-request: check only changed images #890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chmeliik
force-pushed
the
gather-only-changed-images
branch
from
6703391
to
1955039
Compare
mmorhun
reviewed
Mar 20, 2024
mmorhun
reviewed
Mar 20, 2024
task/gather-deploy-images: When the TARGET_BRANCH param is specified, the task will return only the images that differ between the current revision and the target branch. Note that the origin/$TARGET_BRANCH reference must already exist in the cloned repo. The task doesn't have the ability to fetch from private repos, instead it depends on the clone task to fetch everything that's necessary. --- pipelines/gitops-pull-request-rhtap: * add a target-branch param and pass it to gather-deploy-images * pass fetchTags: "true" to the clone task (required for gather-deploy-images to be able to check the target branch) Signed-off-by: Adam Cmiel <[email protected]>
task/gather-deploy-images: When there are no images to check, return an empty string for IMAGES_TO_VERIFY. --- pipelines/gitops-pull-request-rhtap: Run the EC task only if gather-deploy-images gathers some images. Otherwise, the last step of the task (assert) would fail. Signed-off-by: Adam Cmiel <[email protected]>
chmeliik
force-pushed
the
gather-only-changed-images
branch
from
1955039
to
ce5504f
Compare
|
|
re-testing, don't merge yet |
|
Yup, still works 🎉 https://github.com/acmiel-rhtap/rhtap-foo-gitops/pull/1 First the EC check was skipped with no image changes, then it ran as expected (and failed, but for unrelated reasons) |
mmorhun
approved these changes
Mar 20, 2024
jduimovich
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pipeline will only check images that changed in the pull request