Степан Заколюкин

Testing/Basic/Homework/1. ObjectComparison/ObjectComparison.cs

@@ -1,4 +1,5 @@
-using NUnit.Framework;
+using FluentAssertions;
+using NUnit.Framework;
 using NUnit.Framework.Legacy;
 
 namespace HomeExercise.Tasks.ObjectComparison;
@@ -14,16 +15,7 @@ public void CheckCurrentTsar()
         var expectedTsar = new Person("Ivan IV The Terrible", 54, 170, 70,
             new Person("Vasili III of Russia", 28, 170, 60, null));
 
-        // Перепишите код на использование Fluent Assertions.
-        ClassicAssert.AreEqual(actualTsar.Name, expectedTsar.Name);
-        ClassicAssert.AreEqual(actualTsar.Age, expectedTsar.Age);
-        ClassicAssert.AreEqual(actualTsar.Height, expectedTsar.Height);
-        ClassicAssert.AreEqual(actualTsar.Weight, expectedTsar.Weight);
-
-        ClassicAssert.AreEqual(expectedTsar.Parent!.Name, actualTsar.Parent!.Name);
-        ClassicAssert.AreEqual(expectedTsar.Parent.Age, actualTsar.Parent.Age);
-        ClassicAssert.AreEqual(expectedTsar.Parent.Height, actualTsar.Parent.Height);
-        ClassicAssert.AreEqual(expectedTsar.Parent.Parent, actualTsar.Parent.Parent);
+        actualTsar.Should().Be(expectedTsar);
     }
 
     [Test]

Testing/Basic/Homework/1. ObjectComparison/Person.cs

@@ -18,4 +18,23 @@ public Person(string name, int age, int height, int weight, Person parent)
         Weight = weight;
         Parent = parent;
     }
+
+    public override bool Equals(object obj)
+    {
+        if (obj is Person person) return this.GetHashCode() == person.GetHashCode();
+        return false;
+    }
+
+    public int GetHashCode()
+    {
+        var result = 0;
+        var degree = 0;
+        foreach (var field in GetType().GetFields())
+        {
+            if (field.IsStatic || field.Name == "Id") continue;
+            result += (int)Math.Pow(field.GetValue(this).GetHashCode(), ++degree);
+        }
+
+        return result;
+    }
 }

Testing/Basic/Homework/2. NumberValidator/NumberValidator.cs

@@ -14,10 +14,10 @@ public NumberValidator(int precision, int scale = 0, bool onlyPositive = false)
         this.precision = precision;
         this.scale = scale;
         this.onlyPositive = onlyPositive;
-        if (precision <= 0)
-            throw new ArgumentException("precision must be a positive number");
-        if (scale < 0 || scale >= precision)
-            throw new ArgumentException("precision must be a non-negative number less or equal than precision");
+        // if (precision <= 0)
+        //     throw new ArgumentException("precision must be a positive number");
+        // if (scale < 0 || scale >= precision)
+        //     throw new ArgumentException("precision must be a non-negative number less or equal than precision");
         numberRegex = new Regex(@"^([+-]?)(\d+)([.,](\d+))?$", RegexOptions.IgnoreCase);
     }
 

Testing/Basic/Homework/2. NumberValidator/NumberValidatorTests.cs

@@ -8,24 +8,74 @@ namespace HomeExercise.Tasks.NumberValidator;
 public class NumberValidatorTests
 {
     [Test]
-    public void Test()
-    {
-        Assert.Throws<ArgumentException>(() => new NumberValidator(-1, 2, true));
-        Assert.DoesNotThrow(() => new NumberValidator(1, 0, true));
-        Assert.Throws<ArgumentException>(() => new NumberValidator(-1, 2, false));
-        Assert.DoesNotThrow(() => new NumberValidator(1, 0, true));
-
-        ClassicAssert.IsTrue(new NumberValidator(17, 2, true).IsValidNumber("0.0"));
-        ClassicAssert.IsTrue(new NumberValidator(17, 2, true).IsValidNumber("0"));
-        ClassicAssert.IsTrue(new NumberValidator(17, 2, true).IsValidNumber("0.0"));
-        ClassicAssert.IsFalse(new NumberValidator(3, 2, true).IsValidNumber("00.00"));
-        ClassicAssert.IsFalse(new NumberValidator(3, 2, true).IsValidNumber("-0.00"));
-        ClassicAssert.IsTrue(new NumberValidator(17, 2, true).IsValidNumber("0.0"));
-        ClassicAssert.IsFalse(new NumberValidator(3, 2, true).IsValidNumber("+0.00"));
-        ClassicAssert.IsTrue(new NumberValidator(4, 2, true).IsValidNumber("+1.23"));
-        ClassicAssert.IsFalse(new NumberValidator(3, 2, true).IsValidNumber("+1.23"));
-        ClassicAssert.IsFalse(new NumberValidator(17, 2, true).IsValidNumber("0.000"));
-        ClassicAssert.IsFalse(new NumberValidator(3, 2, true).IsValidNumber("-1.23"));
-        ClassicAssert.IsFalse(new NumberValidator(3, 2, true).IsValidNumber("a.sd"));
+    public void NumberValidator_IncorrectPrecision_Exception()
+    {
+        Assert.Throws<ArgumentException>(() => new NumberValidator(-1, 2, true),
+            "precision должен быть положительным числом");
+    }
+
+    [Test]
+    public void NumberValidator_CorrectInitialization_NoExceptions()
+    {
+        Assert.DoesNotThrow(() => new NumberValidator(1, 0, true),
+            "При создании экземпляра класса не должно было возникнуть ошибок");
+    }
+
+    [TestCase(1, -1)]
+    [TestCase(1, 2)]
+    [TestCase(1, 1)]
+    public void NumberValidator_IncorrectScale_Exception(int precision, int scale = 0, bool onlyPositive = true)
+    {
+        Assert.Throws<ArgumentException>(() => new NumberValidator(precision, scale, onlyPositive),
+            "scale должно быть меньше precision, но больше или равно 0");
+    }
+
+    [Test]
+    public void IsValidNumber_InvalidCharacters_False()
+    {
+        ClassicAssert.IsFalse(new NumberValidator(3, 2, true).IsValidNumber("a.sd"),
+            "В записи числа не должны содержаться буквы");
+    }
+
+    [TestCase("00.00", 3, 2)]
+    [TestCase("+1.23", 3, 2)]
+    public void IsValidNumber_NotTheAppropriateLength_False(string value,
+        int precision,
+        int scale = 0,
+        bool onlyPositive = true)
+    {
+        ClassicAssert.IsFalse(new NumberValidator(precision, scale, onlyPositive).IsValidNumber(value),
+            "Длина числа не соответствует шаблону");
+    }
+
+    [TestCase("+1.23", 4, 2)]
+    [TestCase("0", 17, 2)]
+    [TestCase("0.0", 17, 2)]
+    public void IsValidNumber_CorrectValue_True(string value, int precision, int scale = 0, bool onlyPositive = true)
+    {
+        ClassicAssert.IsTrue(new NumberValidator(precision, scale, onlyPositive).IsValidNumber(value));
+    }
+
+    [TestCase("-0.00", 3, 2)]
+    [TestCase("+0.00", 3, 2, false)]
+    public void IsValidNumber_TheWrongSign_False(string value, int precision, int scale = 0, bool onlyPositive = true)
+    {
+        ClassicAssert.IsFalse(new NumberValidator(precision, scale, onlyPositive).IsValidNumber(value),
+            "Знаки value и NumberValidator отличаются");
+    }
+
+    [TestCase("", 1)]
+    [TestCase(null, 1)]
+    public void IsValidNumber_NullOrEmpty_False(string value, int precision, int scale = 0, bool onlyPositive = true)
+    {
+        ClassicAssert.IsFalse(new NumberValidator(precision, scale, onlyPositive).IsValidNumber(value),
+            "Проверяемое значение не должно равняться null или пустой строке");
+    }
+
+    [Test]
+    public void IsValidNumber_InappropriateAccuracy_False()
+    {
+        ClassicAssert.IsFalse(new NumberValidator(17, 2, true).IsValidNumber("0.000"),
+            "значение не может иметь точность выше указанной в NumberValidator");
     }
 }