Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More descriptive listing identifiers #306

Open
codekansas opened this issue Aug 20, 2024 · 3 comments
Open

More descriptive listing identifiers #306

codekansas opened this issue Aug 20, 2024 · 3 comments
Assignees
Labels
backend Feature requests for the backend frontend Feature requests for the frontend

Comments

@codekansas
Copy link
Member

Rather than using something like https://kscale.store/item/abf9cd3c24ccf975 as the listing identifier, we should have something like https://kscale.store/item/ben/stompy to identify listings

@codekansas codekansas assigned codekansas and unassigned codekansas Aug 20, 2024
@codekansas codekansas added frontend Feature requests for the frontend backend Feature requests for the backend labels Aug 20, 2024
@Winston-Hsiao
Copy link
Collaborator

Some clarification questions/things to think about:

  1. Are these something set manually by users who upload? Editable? (would be a new field on listing model called path or something else)
  2. Have to worry about uniqueness (as it's being used for routing)
  3. Have to add secondary db indexes to dynamodb for faster queries (might not be necessary)

@codekansas
Copy link
Member Author

We should have some notion of usernames (and ultimately organization names), then we would have some unique identifier within that user or organization.

I think it is okay if we don't enforce uniqueness at the database level, we might not be able to express this uniqueness within the context of DynamoDB but we can add some checks for this in our CRUD.

@Winston-Hsiao
Copy link
Collaborator

Sounds good will think on the design/implementation plan for that.

@Winston-Hsiao Winston-Hsiao self-assigned this Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Feature requests for the backend frontend Feature requests for the frontend
Projects
Status: Backlog
Development

No branches or pull requests

2 participants