Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upvoted listings #433

Merged
merged 4 commits into from
Oct 1, 2024
Merged

Conversation

ivntsng
Copy link
Member

@ivntsng ivntsng commented Oct 1, 2024

What does this PR do?

This PR enhances the Account UI by introducing the ability for users to view their upvoted posts. It includes the following updates:

  • New Upvoted Posts Section: Adds a new tab that displays posts users have upvoted, providing a dedicated space for users to view all their upvoted content in one place.
  • Pagination for Upvoted Posts: Implements next and previous pagination buttons, allowing users to navigate through their upvoted posts.
  • Backend Integration: The upvoted posts are fetched from the backend using the /listings/upvotes API, and the data is displayed in a grid format using the existing ListingGridCard component.

What issues does this PR fix or reference?

This PR resolves issue #338

If this PR changes the UI, include a screenshot below.

New Overview UI for User's Listings:
Listings_UI

New Upvoted Posts Feature in UI:
User_Upvoted

Copy link
Collaborator

@Winston-Hsiao Winston-Hsiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ivntsng overall looks great, nice implementation, let's just match our theme/UI with our primary orange color rather than blue, and let's use our own gray scale as well. After that it's good to merge.

frontend/src/components/pages/Profile.tsx Outdated Show resolved Hide resolved
frontend/src/components/pages/Profile.tsx Outdated Show resolved Hide resolved
Copy link
Collaborator

@Winston-Hsiao Winston-Hsiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Winston-Hsiao Winston-Hsiao self-requested a review October 1, 2024 23:29
Copy link
Collaborator

@Winston-Hsiao Winston-Hsiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now LGTM

@Winston-Hsiao Winston-Hsiao merged commit fafe47b into kscalelabs:master Oct 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants