-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip to inject the metrics-collector pods to the katib controller #2203
Skip to inject the metrics-collector pods to the katib controller #2203
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f205e94
to
b24cc1e
Compare
Signed-off-by: Yuki Iwai <[email protected]>
b24cc1e
to
4546cc2
Compare
I discussed offline with @andreyvelich and @johnugeorge. Let me summarize. The replicaset controller occasionally faces the following errors since the webhooks are registered to the kube-apiserver before the controller pod is started.
So we set the label to avoid injecting the metrics-collector pod only into the controller pod. Also in the future, we will switch to |
/assign @andreyvelich @johnugeorge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @tenzen-y!
/lgtm
/hold for review
/assign @johnugeorge @gaocegege
/hold cancel |
…beflow#2203) Signed-off-by: Yuki Iwai <[email protected]>
…pods to the katib controller (#2211) Signed-off-by: Yuki Iwai <[email protected]>
What this PR does / why we need it:
I introduced the label to skip injecting the metrics-collector to the katib system components.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #2069
Checklist: