Replace gRPC code generation tool from Znly/protoc to Buf

[forsaken628]

What this PR does / why we need it:
Replace gRPC code generation tool from Znly/protoc to Buf , and some fix

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2141

Checklist:

• Docs included if any changes are user facing

[forsaken628]

medianstop doesn't have any unit tests, and it doesn't look like there's any reason it has to be implemented in python. Can I re-implement it in go later and add unit tests?
@andreyvelich

[andreyvelich]

medianstop doesn't have any unit tests, and it doesn't look like there's any reason it has to be implemented in python. Can I re-implement it in go later and add unit tests?

Actually, we have unit tests here: https://github.com/kubeflow/katib/blob/master/test/unit/v1beta1/earlystopping/test_medianstop_service.py

Any specific reason do you want to implement in Go, ?
We are trying to keep our optimization algorithms in Python since Data Science community are more familiar with it.

[andreyvelich]

Thank you for this great contribution @forsaken628!
I left a few comments.
@tenzen-y @johnugeorge Should we try to merge it before the release to unblock: #2346 ?

[andreyvelich]

Do we need to keep buf config for Go packages outside of /apis/manager/v1beta1 directory ?

[forsaken628]

I'm prefer global buf.gen.yaml, but there will be a lot of changes for python. Well, that's fine.

[andreyvelich]

Thank you for doing this!

[tenzen-y]

Thank you for this great contribution @forsaken628! I left a few comments. @tenzen-y @johnugeorge Should we try to merge it before the release to unblock: #2346 ?

SGTM

[tenzen-y]

@forsaken628 As I mentioned here, could you open a PR to implement the custom readiness check to resolve flake E2E tests?

[tenzen-y]

Thank you for this great contribution!
/approve

I leave lgtm on @andreyvelich

[google-oss-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [tenzen-y]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[forsaken628]

@forsaken628 As I mentioned here, could you open a PR to implement the custom readiness check to resolve flake E2E tests?

katib/cmd/katib-controller/v1beta1/main.go

Line 151 in e6bd3e7

if err := mgr.AddReadyzCheck("readyz", hookServer.StartedChecker()); err != nil {

There's already a webhook ready check added before manger start, and I'm wondering why it's still getting the
connection refused

[tenzen-y]

@forsaken628 As I mentioned here, could you open a PR to implement the custom readiness check to resolve flake E2E tests?

katib/cmd/katib-controller/v1beta1/main.go

Line 151 in e6bd3e7

if err := mgr.AddReadyzCheck("readyz", hookServer.StartedChecker()); err != nil {

There's already a webhook ready check added before manger start, and I'm wondering why it's still getting the connection refused

As I described in the comment, the default checker can not consider if the certs are ready.

https://github.com/kubeflow/training-operator/blob/9a9edecf146bb0c2cccaeb3bec912ab2dfa5d8c5/cmd/training-operator.v1/main.go#L230-L236

[andreyvelich]

Thank you for doing this @forsaken628!
Please can you cherry-pick this PR to the release branch: release-0.17 ?

[andreyvelich]

/lgtm