Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GSoC] Compatibility Changes in Trial Controller #2394

Merged
merged 30 commits into from
Sep 19, 2024
Merged

[GSoC] Compatibility Changes in Trial Controller #2394

merged 30 commits into from
Sep 19, 2024

Commits on Aug 25, 2024

  1. chore: add condition branch in requeue logic. 

    Signed-off-by: Electronic-Waste <[email protected]>
    @Electronic-Waste
    Electronic-Waste committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    4410c1b View commit details
    Browse the repository at this point in the history

  2. chore: add ReportObservationLog in katib_manager_util.go. 

    Signed-off-by: Electronic-Waste <[email protected]>
    @Electronic-Waste
    Electronic-Waste committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    8a92977 View commit details
    Browse the repository at this point in the history

  3. chore: add ReportTrialUnavailableMetrics func. 

    Signed-off-by: Electronic-Waste <[email protected]>
    @Electronic-Waste
    Electronic-Waste committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    4fb810c View commit details
    Browse the repository at this point in the history

  4. chore: insert unavailable value into Katib DB. 

    Signed-off-by: Electronic-Waste <[email protected]>
    @Electronic-Waste
    Electronic-Waste committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    712af68 View commit details
    Browse the repository at this point in the history

  5. fix: fix lint error. 

    Signed-off-by: Electronic-Waste <[email protected]>
    @Electronic-Waste
    Electronic-Waste committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    76e3c95 View commit details
    Browse the repository at this point in the history

  6. fix: add nil condition judgement. 

    Signed-off-by: Electronic-Waste <[email protected]>
    @Electronic-Waste
    Electronic-Waste committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    7f6271b View commit details
    Browse the repository at this point in the history

  7. fix: add nil condition judgement in trial_controller_util.go 

    Signed-off-by: Electronic-Waste <[email protected]>
    @Electronic-Waste
    Electronic-Waste committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    46a5afd View commit details
    Browse the repository at this point in the history

  8. chore(trial): delete nil check of MC kind in the Trial controller. 

    Signed-off-by: Electronic-Waste <[email protected]>
    @Electronic-Waste
    Electronic-Waste committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    59e98a3 View commit details
    Browse the repository at this point in the history

  9. chore(trial): init MC in newFakeTrialBatchJob to avoid nil condition … 

    …in trial reconcile loop.

Signed-off-by: Electronic-Waste <[email protected]>
    @Electronic-Waste
    Electronic-Waste committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    bc9106e View commit details
    Browse the repository at this point in the history

  10. fix(trial): fix lint error. 

    Signed-off-by: Electronic-Waste <[email protected]>
    @Electronic-Waste
    Electronic-Waste committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    a8c9d90 View commit details
    Browse the repository at this point in the history

  11. fix(trial): fix lint error in controller. 

    Signed-off-by: Electronic-Waste <[email protected]>
    @Electronic-Waste
    Electronic-Waste committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    4d1d010 View commit details
    Browse the repository at this point in the history

  12. test(trial): add integration test for Push MC. 

    Signed-off-by: Electronic-Waste <[email protected]>
    @Electronic-Waste
    Electronic-Waste committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    45e4446 View commit details
    Browse the repository at this point in the history

  13. chore(trial): retry reconcilation when reporting unavailable metrics … 

    …failed.

Signed-off-by: Electronic-Waste <[email protected]>
    @Electronic-Waste
    Electronic-Waste committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    e0bd76a View commit details
    Browse the repository at this point in the history

  14. test(trial): fix EXPECT order. 

    Signed-off-by: Electronic-Waste <[email protected]>
    @Electronic-Waste
    Electronic-Waste committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    7971594 View commit details
    Browse the repository at this point in the history

  15. test(trial): fix typo error. 

    Signed-off-by: Electronic-Waste <[email protected]>
    @Electronic-Waste
    Electronic-Waste committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    2b6b4c1 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2024

  1. chore(trial): add errReportMetricsFailed. 

    Signed-off-by: Electronic-Waste <[email protected]>
    @Electronic-Waste
    Electronic-Waste committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    b2872ec View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. Update pkg/controller.v1beta1/trial/trial_controller.go 

    Co-authored-by: Andrey Velichkevich <[email protected]>
Signed-off-by: Electronic-Waste <[email protected]>
    @Electronic-Waste @andreyvelich
    Electronic-Waste and andreyvelich committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    17d5610 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2024

  1. Update pkg/controller.v1beta1/trial/trial_controller_util.go 

    Co-authored-by: Yuki Iwai <[email protected]>
Signed-off-by: Electronic-Waste <[email protected]>
    @Electronic-Waste @tenzen-y
    Electronic-Waste and tenzen-y committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    11d71af View commit details
    Browse the repository at this point in the history

  2. Update pkg/controller.v1beta1/trial/trial_controller.go 

    Co-authored-by: Yuki Iwai <[email protected]>
Signed-off-by: Electronic-Waste <[email protected]>
    @Electronic-Waste @tenzen-y
    Electronic-Waste and tenzen-y committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    303938b View commit details
    Browse the repository at this point in the history

  3. fix(trial): rename errors pkg. 

    Signed-off-by: Electronic-Waste <[email protected]>
    @Electronic-Waste
    Electronic-Waste committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    541ec26 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2024

  1. test(trial): update the order of UT. 

    Signed-off-by: Electronic-Waste <[email protected]>
    @Electronic-Waste
    Electronic-Waste committed Sep 1, 2024
    Configuration menu
    Copy the full SHA
    2fe8c33 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. test(trial): use different names for UTs. 

    Signed-off-by: Electronic-Waste <[email protected]>
    @Electronic-Waste
    Electronic-Waste committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    8495589 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2024

  1. test(trial): separate Push MC UTs with original UTs. 

    Signed-off-by: Electronic-Waste <[email protected]>
    @Electronic-Waste
    Electronic-Waste committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    af40d1f View commit details
    Browse the repository at this point in the history

  2. test(trial): fix line error with gofmt. 

    Signed-off-by: Electronic-Waste <[email protected]>
    @Electronic-Waste
    Electronic-Waste committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    60214c8 View commit details
    Browse the repository at this point in the history

  3. test(trial): reserve one UT for Push MC. 

    Signed-off-by: Electronic-Waste <[email protected]>
    @Electronic-Waste
    Electronic-Waste committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    008a574 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2024

  1. test(trial): fix typo error. 

    Signed-off-by: Electronic-Waste <[email protected]>
    @Electronic-Waste
    Electronic-Waste committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    ffe6089 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. test(trial): make some tiny changes. 

    Signed-off-by: Electronic-Waste <[email protected]>
    @Electronic-Waste
    Electronic-Waste committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    ddd2cb3 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. fix(trial): move cancel func to t.Cleanup. 

    Signed-off-by: Electronic-Waste <[email protected]>
    @Electronic-Waste
    Electronic-Waste committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    6a7a528 View commit details
    Browse the repository at this point in the history

  2. fix(trial): use the propagated gomega instance to improve debuggability. 

    Signed-off-by: Electronic-Waste <[email protected]>
    @Electronic-Waste
    Electronic-Waste committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    7cb4e3e View commit details
    Browse the repository at this point in the history

  3. fix(trial): use gofmt to reformat code. 

    Signed-off-by: Electronic-Waste <[email protected]>
    @Electronic-Waste
    Electronic-Waste committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    9604ed4 View commit details
    Browse the repository at this point in the history